ModEdit/Pcbnew PCB_GENERAL_SETTINGS overlap

[Seth Hillbrand]

Setting any of the preferences in PCB_GENERAL_SETTINGS when both modedit and pcbnew are open are only accepted from modedit.

Steps:
1) Open pcbnew and modedit
2) Open preferences.
3) Try to change Magnetic pad snapping in pcbnew preferences ->This does not work
4) Try to change magnetic pad snapping in modedit preferences ->This does work

Same with limit graphic lines and prefer to selection to dragging

Application: ModEdit
Version: (5.1.0-988-g7d69a917b-dirty), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

Time to eradicate some more globals...

[Jeff Young (jeyjey)]

This could be cherry-picked for 5.1, but I think I'd give it a bit of time in master first.

[KiCad Janitor (kicad-janitor)]

Fixed in revision e785c140b9db212186ecd5cf3047199a0a12b345
https://git.launchpad.net/kicad/patch/?id=e785c140b9db212186ecd5cf3047199a0a12b345