Cannot deploy Octavia on existing Rocky installation

[Anton Antonov]

Description:

  I'm trying to upgrade existing Rocky installation to add Octavia. The deployment fails with erorrs on Undercloud and Controller nodes.

Steps to reproduce:

I use the same deploy command I used for initial deployment with an additional "-e /usr/share/openstack-tripleo-heat-templates/environments/services/octavia.yaml" parameter.

Expected results:

  Octavia successfully deployed.

Actual results:

  This is a snippet of ansible errors I see in the output. Full output log is attached to the bug.

```
TASK [Configure octavia on overcloud] ******************************************
2019-06-13 12:51:31,477 p=294741 u=mistral |
 fatal: [undercloud]: FAILED! => {"changed": true,
 "cmd": "ansible-playbook -i \"/var/lib/mistral/overcloud/octavia-ansible/inventory.yaml\" --extra-vars @\"/var/lib/mistral/overcloud/octavia-ansible/group_vars\"/octavia_vars.yaml \"/usr/share/tripleo-common/playbooks/octavia-files.yaml\" --private-key \"/var/lib/mistral/overcloud/ssh_private_key\"",

 "stderr": "[DEPRECATION WARNING]: get_md5 has been deprecated along with the md5 return value,
 use get_checksum=True and checksum_algorithm=md5 instead. This feature
 will be removed in version 2.9. Deprecation warnings can be disabled by setting
 deprecation_warnings=False in ansible.cfg.",
PLAY [Undercloud[0]] ***********************************************************

TASK [octavia-controller-post-config : read the current IP list] ***************
Thursday 13 June 2019 12:51:28 +0100 (0:00:00.382) 0:02:39.149 *********
fatal: [ap12-ctrl3]: FAILED! => {\"changed\": false,
 \"cmd\": \"crudini --get \\\"/var/lib/config-data/puppet-generated/octavia/etc/octavia/conf.d/octavia-worker/worker-post-deploy.conf\\\" health_manager controller_ip_port_list\",

 \"stderr\": \"[Errno 2] No such file or directory: '/var/lib/config-data/puppet-generated/octavia/etc/octavia/conf.d/octavia-worker/worker-post-deploy.conf'\",

fatal: [ap13-ctrl2]: FAILED! => {\"changed\": false,
 \"cmd\": \"crudini --get \\\"/var/lib/config-data/puppet-generated/octavia/etc/octavia/conf.d/octavia-worker/worker-post-deploy.conf\\\" health_manager controller_ip_port_list\",

 \"stderr\": \"[Errno 2] No such file or directory: '/var/lib/config-data/puppet-generated/octavia/etc/octavia/conf.d/octavia-worker/worker-post-deploy.conf'\",

fatal: [ap14-ctrl1]: FAILED! => {\"changed\": false,
 \"cmd\": \"crudini --get \\\"/var/lib/config-data/puppet-generated/octavia/etc/octavia/conf.d/octavia-worker/worker-post-deploy.conf\\\" health_manager controller_ip_port_list\",

 \"stderr\": \"[Errno 2] No such file or directory: '/var/lib/config-data/puppet-generated/octavia/etc/octavia/conf.d/octavia-worker/worker-post-deploy.conf'\",

TASK [octavia-controller-post-config : restart octavia containers] *************

fatal: [ap12-ctrl3]: FAILED! => {\"changed\": true,
 \"cmd\": \"docker restart $(sudo docker ps -f name=octavia -q)\",
 \"stderr\": \"\\\"docker restart\\\" requires at least 1 argument(s).\
See 'docker restart --help'.\
Usage: docker restart [OPTIONS] CONTAINER [CONTAINER...]\
Restart one or more containers\",

fatal: [ap13-ctrl2]: FAILED! => {\"changed\": true,
 \"cmd\": \"docker restart $(sudo docker ps -f name=octavia -q)\",
 \"stderr\": \"\\\"docker restart\\\" requires at least 1 argument(s).\
See 'docker restart --help'.\
Usage: docker restart [OPTIONS] CONTAINER [CONTAINER...]\
Restart one or more containers\",

fatal: [ap14-ctrl1]: FAILED! => {\"changed\": true,
 \"cmd\": \"docker restart $(sudo docker ps -f name=octavia -q)\",
 \"stderr\": \"\\\"docker restart\\\" requires at least 1 argument(s).\
See 'docker restart --help'.\
Usage: docker restart [OPTIONS] CONTAINER [CONTAINER...]\
Restart one or more containers\",

```

Environment:

  Octavia docker image exists on Controller nodes, but not running containers:

```
[root@ap14-ctrl1 ~]# docker images |grep octavia
docker.io/tripleorocky/centos-binary-octavia-api current-tripleo 7022d7ce3875 5 days ago 1.22 GB
[root@ap14-ctrl1 ~]# docker ps |grep octavia
```

$ rpm -qa|egrep "tripleo|octavia"
puppet-octavia-13.3.2-0.20190531002607.733344b.el7.noarch
openstack-tripleo-puppet-elements-9.0.2-0.20190425202749.1ab58f2.el7.noarch
python-tripleoclient-10.6.2-0.20190522234411.12e3f68.el7.noarch
openstack-tripleo-common-containers-9.5.1-0.20190507224322.cd24177.el7.noarch
ansible-tripleo-ipsec-9.1.1-0.20190513182453.ffe104c.el7.noarch
python2-tripleo-common-9.5.1-0.20190507224322.cd24177.el7.noarch
openstack-tripleo-common-9.5.1-0.20190507224322.cd24177.el7.noarch
python2-octaviaclient-1.6.0-0.20180816134807.64d007f.el7.noarch
ansible-role-tripleo-modify-image-1.0.1-0.20190531141856.f33cad7.el7.noarch
openstack-tripleo-image-elements-9.1.1-0.20190420053043.aa75390.el7.noarch
openstack-tripleo-heat-templates-9.3.1-0.20190531051851.bb4fb9d.el7.noarch
python-tripleoclient-heat-installer-10.6.2-0.20190522234411.12e3f68.el7.noarch
python2-tripleo-repos-0.0.1-0.20190520152004.8a48b48.el7.noarch
openstack-tripleo-validations-9.3.2-0.20190523001404.bf11998.el7.noarch
puppet-tripleo-9.4.1-0.20190601011855.c5986da.el7.noarch

[Brent Eagles (beagles)]

This should be resolved now with Gregory Thiemonge's patches to clean up certificate generation.

[Gregory Thiemonge (gthiemonge)]

Similar to LP 1861413

Should be fixed by (back)porting
https://review.opendev.org/#/c/705093/
https://review.opendev.org/#/c/709089/
from tripleo-ansible