neutron-openvswitch uninstalls haproxy needed by octavia

[Edward Hope-Morley]

I have a non-HA deployment that includes Octavia which includes a relation with neutron-openvswitch. Once I have everything setup it stays in blocked state with the message:

Ports which should be open, but are not: 9876

And sure enough that port is not open. Looking closer I see that the haproxy config was written by the octavia charm but haproxy is not installed. Closer inspection shows that it was installed then purged and it turns out that the purge was done by the local neutron-openvswitch subordianate:

2019-06-13 14:32:58 INFO juju-log neutron-plugin:55: Purging ['haproxy']
2019-06-13 14:32:58 DEBUG neutron-plugin-relation-joined haproxy*
2019-06-13 14:32:59 DEBUG neutron-plugin-relation-joined Removing haproxy (1.8.8-1ubuntu0.4) ...
2019-06-13 14:33:00 DEBUG neutron-plugin-relation-joined Purging configuration files for haproxy (1.8.8-1ubuntu0.4) ...
2019-06-13 14:33:02 DEBUG neutron-plugin-relation-joined Removing user `haproxy' ...
2019-06-13 14:33:02 DEBUG neutron-plugin-relation-joined Warning: group `haproxy' has no more members.
2019-06-13 14:33:02 DEBUG neutron-plugin-relation-joined The group `haproxy' does not exist.
2019-06-13 14:33:02 DEBUG neutron-plugin-relation-joined dpkg: warning: while removing haproxy, directory '/var/lib/haproxy/dev' not empty so not removed

Manually re-installing haproxy fixed the issue.

[Frode Nordahl (fnordahl)]

I believe this was introduced while fixing a different bug: https://review.opendev.org/#/q/topic:bug/1831935+(status:open+OR+status:merged)

Setting high priority as because of the above mentioned fix this also affects the stable charm.

[Edward Hope-Morley (hopem)]

Problem is here - https://github.com/openstack/charm-neutron-openvswitch/blob/master/hooks/neutron_ovs_hooks.py#L180

[Edward Hope-Morley (hopem)]

i.e. if enable-local-dhcp-and-metadata=false AND not using dvr then we purge METADATA_PACKAGES which contains haproxy.

[Frode Nordahl (fnordahl)]

https://review.opendev.org/#/c/665180/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665180
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-openvswitch/commit/?id=0f4eefcf4e208c61e257377211b67ca22dc14d0c
Submitter: Zuul
Branch: master

commit 0f4eefcf4e208c61e257377211b67ca22dc14d0c
Author: Frode Nordahl <email address hidden>
Date: Thu Jun 13 18:48:56 2019 +0200

    Do not remove ``haproxy`` package

    The principal charm may have use for it.

    Change-Id: I342e3be7067a218c466a94728920377367239887
    Closes-Bug: #1832739

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/19.04
Review: https://review.opendev.org/665211

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665211
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-openvswitch/commit/?id=adf5e756a22b294b6c13ca486b12b198bc3fe4b5
Submitter: Zuul
Branch: stable/19.04

commit adf5e756a22b294b6c13ca486b12b198bc3fe4b5
Author: Frode Nordahl <email address hidden>
Date: Thu Jun 13 18:48:56 2019 +0200

    Do not remove ``haproxy`` package

    The principal charm may have use for it.

    Change-Id: I342e3be7067a218c466a94728920377367239887
    Closes-Bug: #1832739
    (cherry picked from commit 0f4eefcf4e208c61e257377211b67ca22dc14d0c)