Undercloud keystone caching enabled with dogpile.cache.null backend

Bug #1832437 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Rabi Mishra

Bug Description

We use ::os_service_default which enables global toggle for keystone caching and also token caching is enabled.

We added keystone::memcache_servers in commit[1]. However, we still use ::os_service_default for cache_backend[2] which sets it to dogpile.cache.null and effectively disabling all caching for keystone.

As we use fernet as the default provider since ocata and memcached service is enabled in undercloud by default. So we should change the driver to use dogpile.cache.memcached instead.

As per keystone docs[3]

"Fernet has the highest scalability characteristics overall, but requires more work to validate, and therefore enabling caching ([cache] enable) is absolutely critical"

[1] https://github.com/openstack/tripleo-heat-templates/commit/19fec5d9d06a84e7dd21e1e60784b48365b34902

[2] https://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L78

[3] https://docs.openstack.org/keystone/latest/admin/configuration.html#performance-and-scaling

Rabi Mishra (rabi)
Changed in tripleo:
assignee: nobody → Rabi Mishra (rabi)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/664781

Changed in tripleo:
status: New → In Progress
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Raised to high as caching should technically boost undercloud capabilities for managing nodes and deployments for the larger scale

Changed in tripleo:
importance: Medium → High
tags: added: rocky-backport-potential stein-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/664781
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e2a4d90aad3a6978ea9a6e4de132adca51df0c15
Submitter: Zuul
Branch: master

commit e2a4d90aad3a6978ea9a6e4de132adca51df0c15
Author: Rabi Mishra <email address hidden>
Date: Wed Jun 12 10:29:25 2019 +0530

    Set cache_backend for token caching

    'fernet' is the token provider since octata. As we've memcached
    in the undercloud, we should enable caching by setting
    cache_backend to 'dogpile.cache.memcached'.

    Change-Id: I4b040d25b2cb83f40cbd8e8caf6890feba586b60
    Closes-Bug: #1832437

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/665277

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/665278

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/665277
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0f5bc4d1b5ceedb6b4b5de6ef16e569d4b349c26
Submitter: Zuul
Branch: stable/stein

commit 0f5bc4d1b5ceedb6b4b5de6ef16e569d4b349c26
Author: Rabi Mishra <email address hidden>
Date: Wed Jun 12 10:29:25 2019 +0530

    Set cache_backend for token caching

    'fernet' is the token provider since octata. As we've memcached
    in the undercloud, we should enable caching by setting
    cache_backend to 'dogpile.cache.memcached'.

    Change-Id: I4b040d25b2cb83f40cbd8e8caf6890feba586b60
    Closes-Bug: #1832437
    (cherry picked from commit e2a4d90aad3a6978ea9a6e4de132adca51df0c15)

tags: added: in-stable-stein
tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.opendev.org/665278
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d37bdf779a351e09cc4b1afa386f647c03d417fe
Submitter: Zuul
Branch: stable/rocky

commit d37bdf779a351e09cc4b1afa386f647c03d417fe
Author: Rabi Mishra <email address hidden>
Date: Wed Jun 12 10:29:25 2019 +0530

    Set cache_backend for token caching

    'fernet' is the token provider since octata. As we've memcached
    in the undercloud, we should enable caching by setting
    cache_backend to 'dogpile.cache.memcached'.

    Change-Id: I4b040d25b2cb83f40cbd8e8caf6890feba586b60
    Closes-Bug: #1832437
    (cherry picked from commit e2a4d90aad3a6978ea9a6e4de132adca51df0c15)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to instack-undercloud (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/665854

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to instack-undercloud (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/665855

Changed in tripleo:
milestone: none → train-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to instack-undercloud (stable/rocky)

Reviewed: https://review.opendev.org/665854
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=b18bfae6903f84dd7db596ee7b5caa3e0b43f0a7
Submitter: Zuul
Branch: stable/rocky

commit b18bfae6903f84dd7db596ee7b5caa3e0b43f0a7
Author: Rabi Mishra <email address hidden>
Date: Tue Jun 18 09:22:18 2019 +0530

    Enable keystone token caching

    'fernet' is the token provider since octata. As we've memcached
    in the undercloud, we should enable caching.

    Change-Id: I4b040d25b2cb83f40cbd8e8caf6890feba586b60
    Related-Bug: #1832437

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to instack-undercloud (stable/queens)

Reviewed: https://review.opendev.org/665855
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=2e54de832e77c15450050300919c481be2ef361f
Submitter: Zuul
Branch: stable/queens

commit 2e54de832e77c15450050300919c481be2ef361f
Author: Rabi Mishra <email address hidden>
Date: Tue Jun 18 09:22:18 2019 +0530

    Enable keystone token caching

    'fernet' is the token provider since octata. As we've memcached
    in the undercloud, we should enable caching.

    Change-Id: I4b040d25b2cb83f40cbd8e8caf6890feba586b60
    Related-Bug: #1832437
    (cherry picked from commit b18bfae6903f84dd7db596ee7b5caa3e0b43f0a7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.4.0

This issue was fixed in the openstack/tripleo-heat-templates 9.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.6.0

This issue was fixed in the openstack/tripleo-heat-templates 10.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.1.0

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.