test_linux_net.LinuxNetTest.test__arp_filtering unit test fails

[Hamdy Khader]

Unit test "vif_plug_ovs.tests.unit.test_linux_net.LinuxNetTest.test__arp_filtering" fails because of
issue in mocking "open" built in function.

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/home/hamdyk/hamdy/PycharmProjects/ovs-dpdk/os-vif/.tox/py27/lib/python3.4/site-packages/mock/mock.py", line 1330, in patched'
    b' return func(*args, **keywargs)'
    b' File "/home/hamdyk/hamdy/PycharmProjects/ovs-dpdk/os-vif/vif_plug_ovs/tests/unit/test_linux_net.py", line 85, in test__arp_filtering'
    b' mock_open.side_effect = mock.mock_open(read_data=mock.Mock())'
    b' File "/home/hamdyk/hamdy/PycharmProjects/ovs-dpdk/os-vif/.tox/py27/lib/python3.4/site-packages/mock/mock.py", line 2517, in mock_open'
    b' _read_data = _to_stream(read_data)'
    b' File "/home/hamdyk/hamdy/PycharmProjects/ovs-dpdk/os-vif/.tox/py27/lib/python3.4/site-packages/mock/mock.py", line 2502, in _to_stream'
    b' return io.StringIO(read_data)'
    b'TypeError: initial_value must be str or None, not Mock'
    b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/664583

[sean mooney (sean-k-mooney)]

setting this to high as it will block other patche form merging

there are actully 2 bug

the one you are fixing and also your python2.7 env is actully using python3.4

i am fixing the second issue as a sperate bug.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/664583
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=1eef2d8a583d251523b02f2fa8a80f946b75d5b1
Submitter: Zuul
Branch: master

commit 1eef2d8a583d251523b02f2fa8a80f946b75d5b1
Author: Hamdy Khader <email address hidden>
Date: Tue Jun 11 15:24:54 2019 +0300

    Fix mock of built in "open" function in unit tests

    Closes-Bug: #1832352
    Change-Id: I37ac054bf8a7ae78492f2c1923ff9dad6a702d9d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665196
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=6e6c0f630005bcdac5d0ecde35ef32dfedad923f
Submitter: Zuul
Branch: stable/stein

commit 6e6c0f630005bcdac5d0ecde35ef32dfedad923f
Author: Hamdy Khader <email address hidden>
Date: Tue Jun 11 15:24:54 2019 +0300

    Fix mock of built in "open" function in unit tests

    Closes-Bug: #1832352
    Change-Id: I37ac054bf8a7ae78492f2c1923ff9dad6a702d9d
    (cherry picked from commit 1eef2d8a583d251523b02f2fa8a80f946b75d5b1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-vif 1.17.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-vif 1.15.2 release.