When deploying a standalone node via an undercloud with network isolation, the deployment fails due to the missing network definitions in the standalone role. These were removed as part of https://review.opendev.org/#/c/628265/ because they became optional.
Steps to Reproduce:
1. Install undercloud
2. make all preparations for Overcloud deployment
3. run overcloud_deploy.sh
Actual results:
Traceback (most recent call last):\\\\n File \"/bin/os-net-config\", line 10, in <module>\\\\n sys.exit(main())\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/cli.py\", line 270, in main\\\\n obj = objects.object_from_json(iface_json)\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 51, in object_from_json\\\\n return OvsBridge.from_json(json)\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 667, in from_json\\\\n members = _update_members(json, nic_mapping, persist_mapping)\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 121, in _update_members\\\\n members.append(object_from_json(member))\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 49, in object_from_json\\\\n return Vlan.from_json(json)\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 521, in from_json\\\\n opts = _BaseOpts.base_opts_from_json(json)\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 416, in base_opts_from_json\\\\n addresses.append(Address.from_json(address))\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 275, in from_json\\\\n ip_netmask = _get_required_field(json, \\\\\\'ip_netmask\\\\\\', \\\\\\'Address\\\\\\')\\\\n File \"/usr/lib/python3.6/site-packages/os_net_config/objects.py\", line 99, in _get_required_field\\\\n raise InvalidConfigException(msg)\\\\nos_net_config.objects.InvalidConfigException: Address JSON objects
require \\\\\\'ip_netmask\\\\\\' to be configured.\\\\n+ RETVAL=1\\\\n+ set -e\\\\n+ [[ 1 == 2 ]]\\\\n+ [[ 1 != 0 ]]\\\\n+ echo \\\\\\'ERROR: os-net-config configuration failed.\\\\\\'\\\\nERROR: os-net-config c
onfiguration failed.\\\\n+ exit 1
Expected results:
Overcloud deployed successfully
Additional info:
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit da1827f7d348fd9
Author: Alex Schultz <email address hidden>
Date: Fri Jun 7 13:44:14 2019 -0600
Add networks to Standalone role
The standalone role can be used with and without an undercloud. If you
deploy it with an undercloud and use network-isolation, then the
deployment will fail because the networks aren't defined in the role.
Since it doesn't hurt to have them on in the non-undercloud version,
lets add them back in. They were previously removed as part of
https:/
Change-Id: I366631cb6ecd39
Closes-Bug: #1832043