os-net-config doesn't respect routes for SR-IOV PF

Bug #1831951 reported by Dan Sneddon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-net-config
Fix Released
High
Dan Sneddon

Bug Description

The schema for os-net-config has routes for SR-IOV PF, they don't ever get written to /etc/sysconfig/network-scripts/route-<PF>. This is because the code is missing to do this in impl_ifcfg.py.

The routes should be implemented just like for regular Ethernet interfaces, so the code implements the schema properly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/663803

Changed in os-net-config:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/666154

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/666155

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/666157

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (master)

Reviewed: https://review.opendev.org/663803
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=b04d8f30d4993fba3e4d207ca698cf10bdf69c2b
Submitter: Zuul
Branch: master

commit b04d8f30d4993fba3e4d207ca698cf10bdf69c2b
Author: Dan Sneddon <email address hidden>
Date: Thu Jun 6 17:01:27 2019 -0700

    Fix handling of SR-IOV PF routes

    Routes on SR-IOV PF interfaces were being ignored in
    impl_ifcfg.py. This change adds route handling for SR-IOV
    interfaces, and a unit test to test writing route files.

    Closes-bug: 1831951
    Change-Id: If41178105229fb9adce9c2950aab39fc55b56166

Changed in os-net-config:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/queens)

Reviewed: https://review.opendev.org/666155
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=6d7e74a381fdd34bc7c7e3e06a7661c1b82fd8d0
Submitter: Zuul
Branch: stable/queens

commit 6d7e74a381fdd34bc7c7e3e06a7661c1b82fd8d0
Author: Dan Sneddon <email address hidden>
Date: Thu Jun 6 17:01:27 2019 -0700

    Fix handling of SR-IOV PF routes

    Routes on SR-IOV PF interfaces were being ignored in
    impl_ifcfg.py. This change adds route handling for SR-IOV
    interfaces, and a unit test to test writing route files.

    Closes-bug: 1831951
    Change-Id: If41178105229fb9adce9c2950aab39fc55b56166
    (cherry picked from commit b04d8f30d4993fba3e4d207ca698cf10bdf69c2b)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/rocky)

Reviewed: https://review.opendev.org/666157
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=c57eb926885bc31e533bffcb93c409fe13e6253b
Submitter: Zuul
Branch: stable/rocky

commit c57eb926885bc31e533bffcb93c409fe13e6253b
Author: Dan Sneddon <email address hidden>
Date: Thu Jun 6 17:01:27 2019 -0700

    Fix handling of SR-IOV PF routes

    Routes on SR-IOV PF interfaces were being ignored in
    impl_ifcfg.py. This change adds route handling for SR-IOV
    interfaces, and a unit test to test writing route files.

    Closes-bug: 1831951
    Change-Id: If41178105229fb9adce9c2950aab39fc55b56166
    (cherry picked from commit b04d8f30d4993fba3e4d207ca698cf10bdf69c2b)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/stein)

Reviewed: https://review.opendev.org/666154
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=28a01544fe5645276ba6ea70369b34d3b7a5a5c5
Submitter: Zuul
Branch: stable/stein

commit 28a01544fe5645276ba6ea70369b34d3b7a5a5c5
Author: Dan Sneddon <email address hidden>
Date: Thu Jun 6 17:01:27 2019 -0700

    Fix handling of SR-IOV PF routes

    Routes on SR-IOV PF interfaces were being ignored in
    impl_ifcfg.py. This change adds route handling for SR-IOV
    interfaces, and a unit test to test writing route files.

    Closes-bug: 1831951
    Change-Id: If41178105229fb9adce9c2950aab39fc55b56166
    (cherry picked from commit b04d8f30d4993fba3e4d207ca698cf10bdf69c2b)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 11.1.0

This issue was fixed in the openstack/os-net-config 11.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 10.4.1

This issue was fixed in the openstack/os-net-config 10.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 9.4.1

This issue was fixed in the openstack/os-net-config 9.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 8.5.1

This issue was fixed in the openstack/os-net-config 8.5.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.