Impossible to change a list of static routes defined for subnet because of InvalidRequestError with Cisco ACI integration

[Nate Johnston]

In a deployment running OpenStack with Cisco ACI integration, unable to change existing list of static routes for all subnets in his environment: after running any command he gets the following error:

InvalidRequestError: Instance <SubnetRoute at 0x7fc1205ddb10> is not present in this Session

After looking for similar issues I have found the following upstream bug and patch:

- https://bugs.launchpad.net/bgpvpn/+bug/1746996
- https://review.opendev.org/#/c/541512/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/663712

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/663713

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/663714

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663714
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=64fb6dd3e2fe54f0131e98baba3429f334843235
Submitter: Zuul
Branch: stable/stein

commit 64fb6dd3e2fe54f0131e98baba3429f334843235
Author: Nate Johnston <email address hidden>
Date: Thu May 30 13:26:13 2019 -0400

    Switch to new engine facade for Route objects

    The Route object is an OVO front for the SubnetRoute model. Enable the
    new Engine Facade code for this object.

    Related-Bug: #1831919
    Change-Id: I5ce1516d38e59d3254b6f684da1384ffd1cecb50
    (cherry picked from commit a9094838a9346ceb0ed54b19646ac8dbf88d6df0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663713
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8ed443ca668c1d8e2d7e9a0503ea02d5b529867d
Submitter: Zuul
Branch: stable/rocky

commit 8ed443ca668c1d8e2d7e9a0503ea02d5b529867d
Author: Nate Johnston <email address hidden>
Date: Thu May 30 13:26:13 2019 -0400

    Switch to new engine facade for Route objects

    The Route object is an OVO front for the SubnetRoute model. Enable the
    new Engine Facade code for this object.

    Related-Bug: #1831919
    Change-Id: I5ce1516d38e59d3254b6f684da1384ffd1cecb50
    (cherry picked from commit a9094838a9346ceb0ed54b19646ac8dbf88d6df0)

[Slawek Kaplonski (slaweq)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/663712
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nate Johnston (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/663712
Reason: Looks like the right things are not there in Queens, so I will accept that this can only be backported to Rocky and no farther.