bump up ng-bootstrap version for Angular staff interface

Bug #1831907 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

The Angular staff interface current requires ng-bootstrap ^3.3.0. It's probably time to bump it up.

The original motivation was getting more keyboard navigation for ngbPopover, which was added in ng-bootstrap 4.1.0, but testing of the patch for bug 1831780 turned up a z-index issue with ng-bootstrap dateselect whose fix is available in 4.1.2.

Revision history for this message
Galen Charlton (gmc) wrote :

Very preliminary testing of ng-bootstrap 4.2.1 did not cause a blowup, so I'll pursue this further.

It does look like this commit (https://github.com/ng-bootstrap/ng-bootstrap/commit/a25d5d2) bears the most testing.

Changed in evergreen:
milestone: none → 3.4-beta1
importance: Undecided → Wishlist
assignee: nobody → Galen Charlton (gmc)
tags: added: angular
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

Just adding a note that I updated my local copy of ng-bootstrap to 4.1.2 and did some tests. I was not able to find any problems.

Revision history for this message
Galen Charlton (gmc) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Galen. Poked around some more and didn't find any issues. Merged to master.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.