Patch - Fix misc. typos

Bug #1831510 reported by kunda1
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Jeff Young

Bug Description

This patch was created using `codespell -q 3 -I ../kicad-white-wordlist.txt -L aray,aother,ba,serie,fo,tim,dout,iff,modul`

Within are patches for the following directories:
pcbnew/
common/
pcb_calculator/
eeschema/

Revision history for this message
kunda1 (kunda1) wrote :
Revision history for this message
Seth Hillbrand (sethh) wrote :

Hi kunda1-

Could you split this out into two patches? One for comments and one for code? That would greatly assist review of this.

Best-
Seth

Revision history for this message
kunda1 (kunda1) wrote :

Hi Seth,
Not for another week or so. Perhaps you could just for this time, review it the way it is? I ask because there are other directories with typos, and there are a lot more typos.

Revision history for this message
Seth Hillbrand (sethh) wrote :

It is unlikely that I'll have immediate time to do this but maybe someone can get to it before then. Unfortunately, tools like this can mix in critical changes (variables/functions/parameters) to code with innocuous changes to comments. The patch is very large and each line needs to be carefully sorted through before we can merge.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@kunda1, I am fine with fixing these typos but I would prefer we wait until right before V6 is released before we merge them. This is a very large change set which will most likely cause merge conflicts when we cherry-pick bug fixes to the 5.1 branch.

Changed in kicad:
status: New → Triaged
importance: Undecided → Wishlist
milestone: none → 6.0.0-rc1
Changed in kicad:
importance: Wishlist → Low
Revision history for this message
Jeff Young (jeyjey) wrote :

A bunch of these are because the wxFormBuilder folks can't spell "override". But since they're in auto-generated files, fixing them doesn't really make any sense.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

I wonder if the wxFormbuilder folks are aware of this? Every file with _base.h in the name cannot be patched so the patch set needs to be updated accordingly.

Revision history for this message
Jeff Young (jeyjey) wrote :

@Wayne there were a bunch of other issues in the patch (such as misspellings in config keys which have to stay), so I've just manually corrected the most egregious cases.

Revision history for this message
Jeff Young (jeyjey) wrote :

Hmmm... that wasn't very clear.

I've manually corrected *in the code* (not *in the patch*)....

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision a25368cc6b0d540b2bdcc25cf96ad7d7e259b8e7
https://git.launchpad.net/kicad/patch/?id=a25368cc6b0d540b2bdcc25cf96ad7d7e259b8e7

Changed in kicad:
status: Triaged → Fix Committed
assignee: nobody → Jeff Young (jeyjey)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.