Manila deployment with NetApp fails due to missing manifest

[Goutham Pacha Ravi]

Steps to reproduce
==================

The overcloud deploy command is as follows:

openstack overcloud deploy \
--timeout 100 \
--templates /usr/share/openstack-tripleo-heat-templates \
--stack overcloud \
--libvirt-type kvm \
-e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml \
-e /home/stack/virt/network/network-environment.yaml \
-e /home/stack/virt/network/dvr-override.yaml \
-e /home/stack/virt/inject-trust-anchor.yaml \
-e /home/stack/virt/hostnames.yml \
-e /home/stack/virt/debug.yaml \
-e /home/stack/virt/nodes_data.yaml \
--environment-file /usr/share/openstack-tripleo-heat-templates/environments/cinder-backup.yaml \
--environment-file /usr/share/openstack-tripleo-heat-templates/environments/manila-netapp-config.yaml \
-e /home/stack/virt/extra_templates.yaml \
-e ~/containers-prepare-parameter.yaml \
--log-file overcloud_deployment.log

Contents of cat /home/stack/virt/extra_templates.yaml:

parameter_defaults:
    ManilaNetappDriverHandlesShareServers: 'false'
    ManilaNetappLogin: NETAPP_USERNAME
    ManilaNetappPassword: NETAPP_USERNAME
    ManilaNetappServerHostname: NETAPP_HOSTNAME
    ManilaNetappTraceFlags: api
    ManilaNetappVserver: NETAPP_VSERVER

Expected result
===============
Overcloud is deployed with manila using the NetApp backend as indicated

Actual result
=============
Deployment fails with the following failure in the log:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/tripleoclient/command.py", line 32, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python3.6/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python3.6/site-packages/cliff/command.py", line 184, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/overcloud_deploy.py", line 925, in take_action
    self._deploy_tripleo_heat_templates_tmpdir(stack, parsed_args)
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/overcloud_deploy.py", line 374, in _deploy_tripleo_heat_templates_tmpdir
    new_tht_root, tht_root)
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/overcloud_deploy.py", line 452, in _deploy_tripleo_heat_templates
    cleanup=(not parsed_args.no_cleanup))
  File "/usr/lib/python3.6/site-packages/tripleoclient/utils.py", line 1133, in process_multiple_environments
    env_path=f.name)
  File "/usr/lib/python3.6/site-packages/heatclient/common/template_utils.py", line 319, in process_environment_and_files
    env_base_url)
  File "/usr/lib/python3.6/site-packages/heatclient/common/template_utils.py", line 357, in resolve_environment_urls
    is_object=is_object, object_request=object_request)
  File "/usr/lib/python3.6/site-packages/heatclient/common/template_utils.py", line 161, in get_file_contents
    file_content = utils.read_url_content(str_url)
  File "/usr/lib/python3.6/site-packages/heatclient/common/utils.py", line 417, in read_url_content
    raise exc.CommandError(_('Could not fetch contents for %s') % url)
heatclient.exc.CommandError: Could not fetch contents for file:///tmp/tripleoclient-8r7j7dko/tripleo-heat-templates/docker/deployment/manila/manila-share-pacemaker-puppet.yaml
Could not fetch contents for file:///tmp/tripleoclient-8r7j7dko/tripleo-heat-templates/docker/deployment/manila/manila-share-pacemaker-puppet.yaml

Environment
===========
Deploying OpenStack Stein with OOO on RHEL

[Jason Grosso (jgrosso)]

https://review.opendev.org/#/c/662306/ code submitted

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/662313

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/662306
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8e4f70322bbf780f8c5ecc7a04260721f285e683
Submitter: Zuul
Branch: master

commit 8e4f70322bbf780f8c5ecc7a04260721f285e683
Author: Jason Grosso <email address hidden>
Date: Thu May 30 15:45:16 2019 -0400

    Fix netapp deployment manifest

    The manifests were moved in change
    I02addc0ecbbbcb60d2c6a0d30d7c9cfa42346f7c.
    However the environment file still referred
    to the old path.

    Change-Id: I09bf2a81099ee1436335c5f58b279929b5fcdbfc
    Closes-Bug: #1831122

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/662313
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=152e4657595a67717152b25b079b2f5cad7ae45c
Submitter: Zuul
Branch: stable/stein

commit 152e4657595a67717152b25b079b2f5cad7ae45c
Author: Jason Grosso <email address hidden>
Date: Thu May 30 15:45:16 2019 -0400

    Fix netapp deployment manifest

    The manifests were moved in change
    I02addc0ecbbbcb60d2c6a0d30d7c9cfa42346f7c.
    However the environment file still referred
    to the old path.

    Change-Id: I09bf2a81099ee1436335c5f58b279929b5fcdbfc
    Closes-Bug: #1831122
    (cherry picked from commit 8e4f70322bbf780f8c5ecc7a04260721f285e683)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.0 release.