[NetApp driver] Vserver deletion tries to acquire lock when it is already locked

[Carlos Eduardo]

When creating and deleting servers, NetApp driver needs to lock a resource for itself.

NetApp driver is having some troubles when it needs to delete some server resources during the server creation. When the driver starts to create a new server and this operation fails, an automatic proccess, that clean all the resources created untill that moment is started. When the deletion is about to start, the removal operation tries to lock a resource that was already locked by the creation proccess, then, the deletion operation will starve.

When the server creation operation fails, the NetApp driver should not try to lock a locked resource.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/662889

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/662889
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4fbf1a2d9ddfd2bb48deaaa264a1dad1aced5370
Submitter: Zuul
Branch: master

commit 4fbf1a2d9ddfd2bb48deaaa264a1dad1aced5370
Author: arthurnsantos <email address hidden>
Date: Tue May 14 17:08:23 2019 -0300

    [NetApp] Fix race condition issues on vserver deletion

    This patch updates the NetApp driver handling with an issue that
    happens when the driver tries to delete the vserver, during a
    rollback operation inside the vserver creation method.

    Change-Id: I0c8468c72e15c1d27f5cdfa50cfc379a9207c5f1
    Closes-bug: #1831092

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667179

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667179
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=49a86d743e5e76513f342250189e9ee3fd1571d4
Submitter: Zuul
Branch: stable/stein

commit 49a86d743e5e76513f342250189e9ee3fd1571d4
Author: arthurnsantos <email address hidden>
Date: Tue May 14 17:08:23 2019 -0300

    [NetApp] Fix race condition issues on vserver deletion

    This patch updates the NetApp driver handling with an issue that
    happens when the driver tries to delete the vserver, during a
    rollback operation inside the vserver creation method.

    Change-Id: I0c8468c72e15c1d27f5cdfa50cfc379a9207c5f1
    Closes-bug: #1831092
    (cherry picked from commit 4fbf1a2d9ddfd2bb48deaaa264a1dad1aced5370)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 8.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 9.0.0.0rc1 release candidate.