Cmd-Q in Eeschema quits KiCad -- doesn't prompt for saving schematic

[Seth Hillbrand]

Previously, pressing Cmd-Q would exit the front-most application. In the latest Mac nightly, starting Eeschema, making a change and pressing Cmd-Q will quit the entire application and not prompt for saving the editing schematic.

Application: KiCad
Version: (5.1.0-727-g66a43612b), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.2.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michael Kavanagh (michaelkavanagh)]

Aside from the not prompting to save, this is sort of more correct, Cmd-Q should quit the entire KiCad process whereas Cmd-W should just close the Eeschema window (see [1]).

[1] https://bugs.launchpad.net/kicad/+bug/1779938

[Jeff Young (jeyjey)]

I tried to move the quit action to an ACTION (so that all frames could share the impl).

However, wxWidgets mucks around with the Quit menu item (and the Preferences one), so I had to put it back. I don't think I've merged it yet though....