Switching canvas no longer works

[Seth Hillbrand]

Since commit a27e4246e0897d03a33120b402c5aea0060319b9, switching canvases in pcbnew only works in one direction (Cairo -> OpenGL). It does not allow switching from OpenGL->Cairo.

Similar/related is that when starting a fresh install, the enable acceleration dialog does not set OpenGL on when requested. You always end up in "Standard Graphics"

Application: Pcbnew
Version: (5.1.0-776-g48899a4c9), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

Note this behavior is seen in all applications, not just pcbnew

[KiCad Janitor (kicad-janitor)]

Fixed in revision 87d997704f610b2334e6f1894528f26d2b6d2854
https://git.launchpad.net/kicad/patch/?id=87d997704f610b2334e6f1894528f26d2b6d2854

[Jeff Young (jeyjey)]

Wow, that was a breath-taking example of a copy/paste bug. ;)

Thanks for cleaning it up for me, @Seth!