Failures when running with Falcon 2.0.0

Bug #1830903 reported by Sean McGinnis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Undecided
Unassigned

Bug Description

There are several test failures when running with the most recent 2.0.0 release of Falcon.

The default values for two options - auto_parse_qs_csv and keep_blank_qs_values - were changed with the 2.0 release, making the results for parsing query parameters as a list return a single list item of all comma separated values. Those now need to be explicitly set to True and False respectively to keep the older existing behavior that the code expects.

Changing those gets unit tests to pass, but the functional tests also fail somewhere in the _auth_app handling (zaqar/transport/middleware/auth.py), maybe with the validator hooks that are run. Stepping through, none of the validators seem to fail, but the zaqar/zaqar/transport/wsgi/driver.py _error_handler hook ends up getting called with a HTTPMethodNotAllowed exception.

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Partial fix for the change in config option defaults included in https://review.opendev.org/661772

Changed in zaqar:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.opendev.org/661772
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=1af2c91e41b147f95082b68e3ec9df95ab458fb2
Submitter: Zuul
Branch: master

commit 1af2c91e41b147f95082b68e3ec9df95ab458fb2
Author: Sean McGinnis <email address hidden>
Date: Tue May 28 09:30:09 2019 -0500

    Unblock gate failures

    There are a few issues causing all gate runs to fail that are addressed
    in this patch.

    Update constraints to match global requirements:

    There are a few local requirements that conflict with what is now in
    upstream global-requirements. This updates sphinx to match the
    constrained versions due to incompatibility with py2 and uncaps
    jsonschema.

    Update handling for falcon 2.0.0 behavior changes:

    The 2.0.0 release of falcon changed the default values for two request
    query parsing options that would cause failures due to unexpected
    results. This sets those options to their previous defaults to maintain
    compatibility across 2.0.0 and pre-2.0.0 versions of the package.
    Lower constraint version raised to 1.1.0 where the options were
    introduced.

    There are additional integration test failures with Falcon 2.0.0 that
    were due to changes in the subscription URL path.

    Closes-bug: #1830903

    Requirements and upper constraints not enforced in some tox targets:

    The docs and api-ref tox targets were not setting the right dependencies
    or the upper constraints to use for pip installs. Also updates the
    constraints to the newer preferred static redirect URL maintained by the
    release team.

    Co-authored-by: wanghao <email address hidden>
    Change-Id: I19c5363878c629a04e1be902c865ee7cea92dcd9
    Signed-off-by: Sean McGinnis <email address hidden>

Changed in zaqar:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/zaqar 9.0.0.0rc1

This issue was fixed in the openstack/zaqar 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.