Crash on invoking find twice in eeschema

[John Beard]

1) Open eeschema
2) Ctrl+F to open find dialog
3) Esc to close it
4) Ctrl+F again -> segfault

Look like unsafe new/delete handling:

-----

#0 0x000055b1b9d4c500 in ()
#1 0x00007fe4e2e0fe77 in SCH_EDIT_FRAME::ShowFindReplaceDialog(bool) (this=
    0x55b1b869a4e0, aReplace=false)
    at /home/john/src/kicad/eeschema/sch_edit_frame.cpp:840
#2 0x00007fe4e2e840a7 in SCH_EDITOR_CONTROL::FindAndReplace(TOOL_EVENT const&)
    (this=0x55b1b86e3c00, aEvent=...)
    at /home/john/src/kicad/eeschema/tools/sch_editor_control.cpp:130
#3 0x00007fe4e2e8e425 in std::__invoke_impl<int, int (SCH_EDITOR_CONTROL::*&)(TOOL_EVENT const&), SCH_EDITOR_CONTROL*&, TOOL_EVENT const&>(std::__invoke_memfun_deref, int (SCH_EDITOR_CONTROL::*&)(TOOL_EVENT const&), SCH_EDITOR_CONTROL*&, TOOL_EVENT const&) (__f=
    @0x55b1b9c69870: (int (SCH_EDITOR_CONTROL::*)(SCH_EDITOR_CONTROL * const, const TOOL_EVENT &)) 0x7fe4e2e84068 <SCH_EDITOR_CONTROL::FindAndReplace(TOOL_EVENT const&)>, __t=@0x55b1b9c69880: 0x55b1b86e3c00, __args#0=...)
....
#10 0x00007fe4e30c66c1 in make_fcontext ()
    at /home/john/src/kicad/build/eeschema/_eeschema.kiface
#11 0x0000000000000000 in ()

----

Application: Eeschema
Version: (5.1.0-667-g840e08fa7), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.1 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.1.1 libpsl/0.20.2 (+libidn2/2.1.1) libssh2/1.8.1 nghttp2/1.36.0
Platform: Linux 5.0.12-arch2-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.1
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 39bb4b639f3a607c6bbdc1bffd0ce5bd7b217d80
https://git.launchpad.net/kicad/patch/?id=39bb4b639f3a607c6bbdc1bffd0ce5bd7b217d80