tripleo

Incorrect sample_default for host_routes in undercloud.conf

Bug #1830093 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Harald Jensås
tripleo train-1

Bug Description

https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/config/undercloud.py#L389

  sample_default=('[{destination: 10.10.10.0, '
                  'nexthop: 192.168.24.1}]'),

The sample default is incorrect, it should include a subnet mask prefix for the destination.

  sample_default=('[{destination: 10.10.10.0/24, '
                  'nexthop: 192.168.24.1}]'),

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/660833

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/660833
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=cc6ddee223c9f9a7e1c77cd426757271c844aeba
Submitter: Zuul
Branch: master

commit cc6ddee223c9f9a7e1c77cd426757271c844aeba
Author: Harald Jensås <email address hidden>
Date: Wed May 22 19:22:33 2019 +0200

    Fix sample_default for host_routes option

    The host_routes option sample default was missing
    the subnet prefix for the destination ip network.

    Closes-Bug: #1830093
    Change-Id: I9bb3160f1bb50b410ec9f9b6751463b847d8a920

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/661261

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/stein)

Reviewed: https://review.opendev.org/661261
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=c67f48629850e69b3c1996d455824147bec1dbb9
Submitter: Zuul
Branch: stable/stein

commit c67f48629850e69b3c1996d455824147bec1dbb9
Author: Harald Jensås <email address hidden>
Date: Wed May 22 19:22:33 2019 +0200

    Fix sample_default for host_routes option

    The host_routes option sample default was missing
    the subnet prefix for the destination ip network.

    Closes-Bug: #1830093
    Change-Id: I9bb3160f1bb50b410ec9f9b6751463b847d8a920
    (cherry picked from commit cc6ddee223c9f9a7e1c77cd426757271c844aeba)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.0.0

This issue was fixed in the openstack/python-tripleoclient 12.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 11.5.0

This issue was fixed in the openstack/python-tripleoclient 11.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.