Eeschema: missing convert text type context menu

[Wayne Stambaugh]

It looks like the convert schematic text to a label type submenu has not been implemented in the new tool framework. This includes the following command IDs: ID_POPUP_SCH_CHANGE_TYPE_TEXT_TO_LABEL, ID_POPUP_SCH_CHANGE_TYPE_TEXT_TO_HLABEL, ID_POPUP_SCH_CHANGE_TYPE_TEXT_TO_GLABEL, and ID_POPUP_SCH_CHANGE_TYPE_TEXT.

Application: Eeschema
Version: (5.1.0-620-gd701637ea), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: Clang 7.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

    static TOOL_ACTION toLabel;
    static TOOL_ACTION toHLabel;
    static TOOL_ACTION toGLabel;
    static TOOL_ACTION toText;

Are they not working?

(I did drop the sub-menu; they should appear on the main context menu whenever an applicable object is selected.)

[Wayne Stambaugh (stambaughw)]

@Jeff, not on linux anyway. I haven't checked it on windows. If I right click on a label or a text object and it should show the convert to label types submenu. I would send a screenshot but I cannot take a screenshot on linux when a context menu is open.

[Seth Hillbrand (sethh)]

@Wayne/Jeff-

It works for me on Debian, when trying to convert a text object to label. Although I get a segfault when undoing the action.

I don't get the menu when right-clicking on a local label.

[Michael Kavanagh (michaelkavanagh)]

I don't see any such menu or submenu on macOS.

Application: Eeschema
Version: (5.1.0-620-gd701637ea), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.5.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 10.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jon Evans (craftyjon)]

FYI Wayne, Shutter on Linux can take screenshots including context menus
https://launchpad.net/shutter

I also don't see these menu objects when right-clicking on text objects:
https://i.imgur.com/aOTSluj.png

[jean-pierre charras (jp-charras)]

I also don't see any such menu or submenu on W7.

[Seth Hillbrand (sethh)]

@Jon- It looks like you are clicking on a local label. If you place a text object, do you get the menu?

[Jon Evans (craftyjon)]

No, I don't get the menus for any label type or graphic text.

[Seth Hillbrand (sethh)]

Wait, you get the menu when you are in the text tool (or label tool) But not when you are in select tool.

[Jon Evans (craftyjon)]

Ah, you are right. If I enter the text tool, then I can change types (of any type of text). I also see that if I convert any label type to a graphic text, it still gets a dangling end indicator sticking around.

[Wayne Stambaugh (stambaughw)]

It should work in the selection tool because the context is an SCH_TEXT object or derived from SCH_TEXT so all actions allowed on one of these objects should be in the context menu.

[Jeff Young (jeyjey)]

Dang, it's another case of allocating a KICAD_T[] on the stack. Fix coming.

[Jeff Young (jeyjey)]

(Probably explains the somewhat random behaviour too: sometimes the stack frame hasn't yet been overwritten and sometimes it has.)

[KiCad Janitor (kicad-janitor)]

Fixed in revision fbffb9ae1e5711bed884265783cd48dc586a6cde
https://git.launchpad.net/kicad/patch/?id=fbffb9ae1e5711bed884265783cd48dc586a6cde