Import sheet pin doesn't work and resize block unconnect ports

[Hildo Guillardi Júnior]

Import sheet pin in hierarchical block doesn't work at last Nightly.

Application: Eeschema
Version: 6.0.0-unknown-a32bb4e~86~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.15.0-50-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Hildo Guillardi Júnior (hildogjr)]

Other problem related is that resizing the hierarchical block it broke the port connection (they stay out of new block if you resize to a small size).

[Hildo Guillardi Júnior (hildogjr)]

The expected behavior is:
1) Moving the up left/right hierarchical block up the block will resize to top keeping the port positions at the sheet (fixed to the bottom part of the block);
2) Same but opposite when resizing by the bottom corners (the port will keep the reference at the top of the block);
3) The minimum size is fixed to contain all the already placed ports;
4) Moving the right corners to left-to-rigth (and vice-versa) the right ports x-axis position will change consistently;
5) Same to the other side.

[Hildo Guillardi Júnior (hildogjr)]

@Jeff, is this on 20190517 Nightly release? Warning me if I am wrong.

Because: the resize behavior is fixed (not as I proposed above, keeping the port positions when it is resized on top) but the "import sheet pin / port" doesn't work and sometimes show, at least in one test, a different behavior when is accessed by the right button menu and by the lateral toolbar.

Summarizing:
I could add the ports by the lateral menu access at opened a "Sheet Pin Properties", so I manually add the port name that I wanted, this procedure was not automatically as before.
By the right button always goes wrong, it manually too but at the end the port stay "unconnected with the block". If I resize it, the port stay and don't move.

[Jeff Young (jeyjey)]

@Hildo, there was already code from 5.0 for resizing, it just wasn't getting called. So it now does the same thing as in 5.0.

The context menu issue is because the wrong action is in there: it's just selecting the Import Sheet Pin tool, rather than importing a sheet pin. Fix on the way....

[KiCad Janitor (kicad-janitor)]

Fixed in revision 7c25001622b619d8ffbec9ad5cca51438f522ebf
https://git.launchpad.net/kicad/patch/?id=7c25001622b619d8ffbec9ad5cca51438f522ebf

[Dino Ghilardi (dino-ghilardi)]

Still "import hierarchical sheet pin" from the toolbar does not import the pin but opens the same dialog as "Add a sheet pin", just as if the callback for both the buttons in the toolbar is the same.

Note: selecting the child sheet and using the right click menu "Import sheet pin" works correctly.

Tested on revision b0c1c1ad2b8a99cc46bd633ea4d81f7492e6984b.

-------------------------------
Application: Eeschema
Version: (5.1.0-1054-gb0c1c1ad2), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2r zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michael Kavanagh (michaelkavanagh)]

@Dino, Please open a new bug report to enable us to verify, assign a milestone and track this issue.