Path Substitutions section of library setup dialog has poor column names

Bug #1828459 reported by Evan Shultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Low
Wayne Stambaugh

Bug Description

The Path Substitutions section of the library setup dialog contains the key/value pairs of the env vars. Column A is the env var name and column B is the env var value. See the screenshot in the next post for clarity about one place in the UI where this happens for the footprint library (the schematic libraries have a similar dialog and possibly there are others).

Naming columns "A" and "B" seems like a placeholder or oversight. Wouldn't "Key"/"Value" or "Name"/"Value" be more salient column names?

Application: kicad
Version: (5.1.2)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: ui
Revision history for this message
Evan Shultz (evan-shultz) wrote :
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

That's a case of being way too close to the code base. Has it always been this way and if so how did that get missed?

Changed in kicad:
status: New → Triaged
importance: Undecided → Low
milestone: none → 5.1.3
tags: added: ui
Changed in kicad:
assignee: nobody → Wayne Stambaugh (stambaughw)
Changed in kicad:
status: Triaged → In Progress
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

Apparently the janitor didn't pick this up. The commit in master is https://git.launchpad.net/kicad/commit/?id=6f27ef7f663a0cdaaa355e62de66fa71f11cadc2.

Changed in kicad:
status: In Progress → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.