Pcbnew doesn't save board settings

[Leandro Heck]

This is a little bit annoying. Previews versions didn't have this issue.

Application: kicad
Version: 5.1.2-f72e74a~84~ubuntu19.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.8.6/openssl/zlib nghttp2/1.36.0 librtmp/2.3
Platform: Linux 5.0.0-13-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michael Kavanagh (michaelkavanagh)]

I've confirmed the ratsnest visibility setting is not saved/loaded on 5.1.2 and master, but I cant find the commit hash in the version info provided so may have milestoned wrong.

[Seth Hillbrand (sethh)]

It's not just ratsnest but all layers/netclasses/track settings that are meant to go into the project file.

[KiCad Janitor (kicad-janitor)]

Fixed in revision e7e20b85b5275fabe2677d3bdb453c021dd791a9
https://git.launchpad.net/kicad/patch/?id=e7e20b85b5275fabe2677d3bdb453c021dd791a9

[Seth Hillbrand (sethh)]

My first impression was incorrect here. These are visibility settings that are stored in the board file. The plan during v6 is to move these settings to a separate file. But for now, we should respect the board file and minimize churn in the saved file.