[2.6b3, websocket, ESXi] Adding a disk to an existing datastore
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Blake Rouse |
Bug Description
Problem:
When calling the `update_
Potential solution:
The datastore_id that is being sent is incorrect. This is due to an oversight on my part. When the websocket dehydrates block devices it dehydrates the virtual block device for the VMFS datastore giving it the virtual block device ID, not the datastore id.
I see two ways to fix this on the back end
1. The simple way would be to search for the virtual block id or the datastore id. This[1] patch does that but its still failing. For some reason the UI is sending an invalid partition to remove as well.
2. Specifically dehydrate VMFS. We do this for LVM and Bcache already. This may change how the data over the websocket needs to be read.
I apologize for the oversight.
Related branches
- Andres Rodriguez (community): Approve
-
Diff: 36 lines (+3/-4)2 files modifiedsrc/maasserver/websockets/handlers/machine.py (+1/-2)
src/maasserver/websockets/handlers/tests/test_machine.py (+2/-2)
Changed in maas: | |
assignee: | nobody → Blake Rouse (blake-rouse) |
milestone: | none → 2.6.0rc1 |
importance: | Undecided → Critical |
status: | New → Triaged |
summary: |
- [2.6b3, websocket] Adding a disk to an existing datastore + [2.6b3, websocket, ESXi] Adding a disk to an existing datastore |
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 2.6.0rc1 → 2.6.0beta4 |
Changed in maas: | |
status: | Fix Committed → Fix Released |