Copy-paste add symbol to library and hieararchical sheets to folder

[Hildo Guillardi Júnior]

I just copied a eschematic part between project, finally this amazing needed feature is on Nightly. But there is a issue, when I paste a circuit with a part that is not in current project/global library it is not recognize.

The expected behavior of this feature is:
1) Check if all part symbol are global;
2) If some are project local, copy also them;
3) Paste the schematic part pasting the not added symbol to the current cache project.

Application: eeschema
Version: 6.0.0-unknown-09c9db4~86~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.4.0-146-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michael Kavanagh (michaelkavanagh)]

There should definitely be a dialog asking you to confirm the changes (adding the missing library to the table?) and whether to proceed.

[Hildo Guillardi Júnior (hildogjr)]

Good idea @Michael. The dialog could have the options:

Cancel - to cancel the paste
Ignore - will not add but will do the paste
Add to cache (this should be the default)
Add to specific library - this will open the "Save Copy of Symbol" dialog that belongs to "Symbol Editor"

[Hildo Guillardi Júnior (hildogjr)]

Popup message:
"It was detect symbol(s) that doesn't belong(s) to any existent library of current project. How do you want do proceed?"

[Hildo Guillardi Júnior (hildogjr)]

From discussion at lp:1828222 I realize that the hierarchical sheet files could be copied, with confirmation to rename, to the current project folder.

[Anton (antonpupkov)]

If libraries are available, no problems must be. Symbols must be available regardless of hierarchy

[Hildo Guillardi Júnior (hildogjr)]

@anton,2 not related problem here: copy the symbols and copy the hierarchical sheets (in loop in case of hierarchical sheets inside the copied one).

[Hildo Guillardi Júnior (hildogjr)]

Also, necessary to check the symbols availability when coping each hierarchical sheet and add the available to the current project.
The message to do this should be show just once, not each symbol occurrence.

[Seth Hillbrand (sethh)]

I think this bug will wait for the new schematic format that with embedded symbols.

[KiCad Janitor (kicad-janitor)]

KiCad bug tracker has moved to Gitlab. This report is now available here: https://gitlab.com/kicad/code/kicad/-/issues/2407