Join sound plays when IRC user joins Lobby
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Won't Fix
|
Low
|
Unassigned | ||
Bug Description
Currently the join sound is played when an IRC-user joins the lobby. The problem is that, currently we do not show join messages for IRC users.
Thist is quite confusing.
The reason is that, in internet-lobby.cc we only compare list sizes and not the actual content when playing the sound.
I accidentally fixed this here:
lp:~widelands-dev/widelands/bug-1827182-sort-client-list
So join messages for IRC users are displayed now. But not leave messages. I think it is useful to notify the user about joining/parting IRC users since we already display them in the lobby. Also some users use the IRC web chat on our website to ask questions about widelands.
So IRC shouldn't be kept silence. I would push the change to the above mentioned branch. Since it hasn't been merged because travis failed on the input test.
Related branches
- GunChleoc: Approve
-
Diff: 186 lines (+42/-16)6 files modifiedsrc/network/internet_gaming.cc (+10/-11)
src/ui_basic/panel.h (+1/-2)
src/ui_fsmenu/internet_lobby.cc (+12/-3)
src/ui_fsmenu/launch_mpg.cc (+6/-0)
src/wui/game_chat_panel.cc (+12/-0)
src/wui/game_chat_panel.h (+1/-0)
| Changed in widelands: | |
| status: | New → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Toni Förster (stonerl) |
| milestone: | none → build21-rc1 |
| Changed in widelands: | |
| assignee: | Toni Förster (stonerl) → nobody |
| status: | In Progress → Fix Committed |
| GunChleoc (gunchleoc) wrote | #1 |
| Changed in widelands: | |
| status: | Fix Committed → Won't Fix |
Migrated to https:/