ntp service is still incorrectly referenced in roles and environment files

[Alex Schultz]

The direct usage of OS::TripleO::Services::Ntp should no longer be defined for role services as it has been replaced by OS::TripleO::Services::Timesync. If you define both, you could end up with conflicting service configurations.

[Vadim Khitrin (vkhitrin)]

Can confirm that this is occurring for NFV (but not unique to NFV as per bug's description) deployments when attempting to deploy compute nodes using generated 'ComputeOvsDpdkSriov' role (https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/roles/ComputeOvsDpdkSriov.yaml).

'OS::TripleO::Services::Ntp' calls deployment/time/ntp-baremetal-puppet.yaml 'https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/time/ntp-baremetal-puppet.yaml' which contain Ansible tasks(L108-L115) which attempt to install 'ntpdate' which is not possible on RHEL8 or is not found in the repos that are shipped with overcloud image.

Attaching Ansible log for deployment for more info.

[Alex Schultz (alex-schultz)]

https://review.opendev.org/#/c/657035/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/657035
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=90562b6f5d17240e59a7f229091e704da2c0ff62
Submitter: Zuul
Branch: master

commit 90562b6f5d17240e59a7f229091e704da2c0ff62
Author: Alex Schultz <email address hidden>
Date: Fri May 3 14:36:10 2019 -0600

    Use timesync service

    The Ntp service should no longer defined on the roles as we should be
    using the meta Timesync service to ensure the correct service is defined
    for the sync service.

    Change-Id: Ic2fb3291de78891d05ef12e3778263fe74fbff8c
    Related-Blueprint: tripleo-chrony
    Closes-Bug: #1827676

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/657604

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/657604
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=eb898e2349e1f280243e14cb0084d1f7572a58f6
Submitter: Zuul
Branch: stable/stein

commit eb898e2349e1f280243e14cb0084d1f7572a58f6
Author: Alex Schultz <email address hidden>
Date: Fri May 3 14:36:10 2019 -0600

    Use timesync service

    The Ntp service should no longer defined on the roles as we should be
    using the meta Timesync service to ensure the correct service is defined
    for the sync service.

    Change-Id: Ic2fb3291de78891d05ef12e3778263fe74fbff8c
    Related-Blueprint: tripleo-chrony
    Closes-Bug: #1827676
    (cherry picked from commit 90562b6f5d17240e59a7f229091e704da2c0ff62)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.0 release.