PCBNew: Text is not detected even if the mouse is over it

[Silviu Laurentiu]

1. Press M (from Move) to move the TC1 reference.
2. BUG: Even if the mouse is over the text, the text (reference) is not detected

Please have a look on the attached video

Application: kicad
Version: (5.1.2)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michael Kavanagh (michaelkavanagh)]

Could you upload a project that exhibits this? It would greatly help in figuring out the issue.

[Michael Kavanagh (michaelkavanagh)]

I can't reproduce this on macOS using 5.1.2 or latest master. @Anyone else?

[Jeff Young (jeyjey)]

I just fixed a similar bug in 6.0, which appears to have been in the code for some time. While it might not fix this, I think it's worth merging back to 5.1.2.

However, it will take me hours to switch away from eemodern to build it. The fix is to add a copy constructor to EDA_TEXT:

EDA_TEXT::EDA_TEXT( const EDA_TEXT& aText ) :
    m_Text( aText.m_Text ),
    m_e( aText.m_e )
{
    m_shown_text = UnescapeString( m_Text );
}

so that m_shown_text get re-calculated on a copy. Anyone else have time to give this a try and merge it? (If not I can do it next week.)

[Jeff Young (jeyjey)]

The 5.1 code is different enough here that the changes can't be applied directly. Since I'm not even sure it's the same bug, I'm not going to attempt to apply the other fix.