no join message when lobby & IRC name are equal
Bug #1827275 reported by
Toni Förster
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Won't Fix
|
Undecided
|
Unassigned | ||
Bug Description
Since we allow registered user to have a name that is already present in IRC, join messages for these users are not shown any more. That is because the client confuses IRC and lobby clients.
We just need to additionally check the client type before deciding whether the client has already joined or not.
I prepared two branches, one for build-20 and one for trunk.
Related branches
lp:~widelands-dev/widelands/bug-1827275-join_message_irc-lobby-build20
- Widelands Developers: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/network/internet_gaming.cc (+1/-1)
lp:~widelands-dev/widelands/bug-1827275-join_message_irc-lobby
- GunChleoc: Approve
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/network/internet_gaming.cc (+1/-1)
| tags: | added: multiplayer ui |
| Changed in widelands: | |
| status: | New → Fix Committed |
| milestone: | none → build21-rc1 |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
| Changed in widelands: | |
| status: | Fix Committed → Won't Fix |
To post a comment you must log in.
Migrated to https:/