Pending friends card has extra white space under request message

Bug #1826954 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Evonne Cheung

Bug Description

The pending friends card seems to have excess white space underneath the request message (please see attached screenshot).

To replicate:
Have two users.
1. Log in as user A and send a friendship request to user B.
2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications.
3. Click on the pending request to be taken to the user A profile (click on their user name)
4. Observe the pending friend request card

Expected results:
All elements display correctly
Actual results:
There is extra white space underneath the friendship request message.

Testing in themes: raw, default, modern on Firefox.

Revision history for this message
Lisa Seeto (lisaseeto) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9914

Evonne Cheung (evonne)
Changed in mahara:
status: New → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → In Progress
milestone: none → 19.04.0
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9914
Committed: https://git.mahara.org/mahara/mahara/commit/6cc2ccd036aa91ffdfad0889ad5de47153fde74e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6cc2ccd036aa91ffdfad0889ad5de47153fde74e
Author: Evonne Cheung <email address hidden>
Date: Tue Apr 30 12:33:16 2019 +1200

Bug #1826954 Pending friends card has extra white space under request message

Fixed warning status card-body to white, also fixed the warning
footer which was wrongly inheriting info color.

behatnotneeded

Change-Id: Ib8407b65d963bca2e637c296e2c6c23f1e4da645

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9918

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9918
Committed: https://git.mahara.org/mahara/mahara/commit/f69d794145b4505ed2400fdc3df6b5d0416898f6
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit f69d794145b4505ed2400fdc3df6b5d0416898f6
Author: Evonne Cheung <email address hidden>
Date: Tue Apr 30 12:33:16 2019 +1200

Bug #1826954 Pending friends card has extra white space under request message

Fixed warning status card-body to white, also fixed the warning
footer which was wrongly inheriting info color.

behatnotneeded

Change-Id: Ib8407b65d963bca2e637c296e2c6c23f1e4da645
(cherry picked from commit 6cc2ccd036aa91ffdfad0889ad5de47153fde74e)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.