Fp editor still has "Save changes to board" after saving the opened fp into a library

[eelik]

1. Open a footprint from a board.
2. The toolbar has "Save changes to board" button and icon.
3. File->Save As... and save to a library.
4. The toolbar has still "Save changes to board" button and icon.

It should be changed to normal Save because it won't be saved to the board anymore.

Application: kicad
Version: (5.1.0)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[jean-pierre charras (jp-charras)]

Why do you think it should not also be saved on board, if it comes from the board?

[John Beard (john-j-beard)]

I think this is a bug. This is normal:

1) Edit footprint in Pcb (Ctrl-E)
2) Toolbar button is "Update footprint on board"
3) Choose a different footprint in a library
4) Toolbar button changes to "Save"

However, if you do:

1) Edit footprint in Pcb (Ctrl-E)
2) Toolbar button is "Update footprint on board"
3) Save As a different footprint in a library
4) Toolbar button doesn't change. However, clicking acts to Save the footprint in the library not the PCB. So the action is correct, but the icon and tooltip are wrong.

[Wayne Stambaugh (stambaughw)]

Just so I clear, the issue here just the icon and the tooltip are wrong not the actual behavior?

[eelik (eelik)]

Yes, that's my opinion. It's logical that if I use Save As, just like in any other software, the further edits go to the latest saved version, not to other versions saved elswhere. In this case it's logical that only the version saved to a library with Save As is edited, not the module which is in the board. But the tooltip and icon don't reflect that actual behavior.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 1ef2f84f72d87760b702515adf2f6df80c944fb7
https://git.launchpad.net/kicad/patch/?id=1ef2f84f72d87760b702515adf2f6df80c944fb7