Inconsistent threadTrace type int/string in JSON

[James Fournie]

Testing on demo.evergreencatalog.com using osrf-websocket-translator

It seems like messages sent to Perl services (open-ils.actor, open-ils.pcrud) get a response like:

"threadTrace": 0

However messages coming from C services (open-ils.auth, opensrf.open-ils.system.fieldmapper), give a response like:

"threadTrace": "0"

This makes it difficult to write a OpenSRF client in a strongly typed language such as Golang.

I found threadTrace is set in the following places:

Perl Code:

https://github.com/evergreen-library-system/OpenSRF/blob/d7e9df6838f1c9a72db3fd41556d178cfe7f6700/src/perl/lib/OpenSRF/Server.pm#L254

https://github.com/evergreen-library-system/OpenSRF/blob/71720f639e00d0e457bc8f967f8060b579bc2882/src/perl/lib/OpenSRF/DomainObject/oilsMessage.pm#L172

https://github.com/evergreen-library-system/OpenSRF/blob/304365165e7ba0cc08bb6c5f0ba25f0b541fd27d/src/perl/lib/OpenSRF/AppSession.pm#L526

C Code:
https://github.com/evergreen-library-system/OpenSRF/blob/71720f639e00d0e457bc8f967f8060b579bc2882/src/libopensrf/osrf_message.c#L438

I haven't checked the Python or Java libraries.

[Jason Stephenson (jstephenson)]

"I haven't checked the Python or Java libraries."

And, there is no need. They are almost never used and Java, at least, will be removed, soon. I still have to make a bug for that, but now is probably a good time.

Python needs a maintainer or it will be removed.