Pod SG not updated when NP podSelector is updated

Bug #1826548 reported by Maysa de Macedo Souza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kuryr-kubernetes
Fix Released
Undecided
Maysa de Macedo Souza

Bug Description

When the podSelector of a Network Policy Spec is updated from '{}' to any other value, the pods that are not supposed to be enforced by the policy anymore do not have their Security Group updated to the default one.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kuryr-kubernetes (master)

Fix proposed to branch: master
Review: https://review.opendev.org/655902

Changed in kuryr-kubernetes:
assignee: nobody → Maysa de Macedo Souza (maysa)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kuryr-kubernetes (master)

Reviewed: https://review.opendev.org/655902
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=59e761afbf838d10484baeb0564db9ae4d5867b1
Submitter: Zuul
Branch: master

commit 59e761afbf838d10484baeb0564db9ae4d5867b1
Author: Maysa Macedo <email address hidden>
Date: Fri Apr 26 13:33:16 2019 +0000

    Ensure Pod SG is updated on podSelector of NP spec update

    When the podSelector of a Network Policy Spec is updated from '{}'
    to any other value, the pods that are not supposed to be enforced
    by the policy anymore do not have their Security Group updated
    to the default one. This commit fixes the issue by also taking into
    account the possible value of '{}' in the podSelector NP spec.

    Change-Id: I35519acfdf8ef250880e36bcf789c063ba86b31e
    Closes-Bug: 1826548

Changed in kuryr-kubernetes:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kuryr-kubernetes (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/661570

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kuryr-kubernetes (stable/stein)

Reviewed: https://review.opendev.org/661570
Committed: https://git.openstack.org/cgit/openstack/kuryr-kubernetes/commit/?id=53ffeb980ce2a8958151070b8b2866e15f983846
Submitter: Zuul
Branch: stable/stein

commit 53ffeb980ce2a8958151070b8b2866e15f983846
Author: Maysa Macedo <email address hidden>
Date: Fri Apr 26 13:33:16 2019 +0000

    Ensure Pod SG is updated on podSelector of NP spec update

    When the podSelector of a Network Policy Spec is updated from '{}'
    to any other value, the pods that are not supposed to be enforced
    by the policy anymore do not have their Security Group updated
    to the default one. This commit fixes the issue by also taking into
    account the possible value of '{}' in the podSelector NP spec.

    Change-Id: I35519acfdf8ef250880e36bcf789c063ba86b31e
    Closes-Bug: 1826548
    (cherry picked from commit 59e761afbf838d10484baeb0564db9ae4d5867b1)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kuryr-kubernetes 1.1.0

This issue was fixed in the openstack/kuryr-kubernetes 1.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.