[UI, UX] Machine page forgets which tab was open upon refresh
Bug #1826174 reported by
Lilyana Videnova
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Medium
|
Steve Rydz |
Bug Description
I am on the storage tab of a machine and hit refresh I should be returned to the same tab, not the summary page.
The same is true for controllers.
Related branches
~steverydz/maas:add-url-params-for-tabs
Merged
into
maas:master
- Anthony Dillon: Approve
- Blake Rouse (community): Approve
-
Diff: 114 lines (+27/-12)3 files modifiedsrc/maasserver/static/js/angular/controllers/node_details.js (+6/-0)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+9/-0)
src/maasserver/static/partials/node-details.html (+12/-12)
Changed in maas: | |
assignee: | nobody → Steve Rydz (steverydz) |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 2.6.0 → 2.6.0rc1 |
Changed in maas: | |
milestone: | 2.6.0rc1 → 2.6.0beta4 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
FYI the UI does accept an area parameter on the node details page to select which tab should be displayed. This is how the 'Back to machine details' link works when viewing the log of a commissioning or hardware test script. I tried using this to fix refresh and allow the forward and back browser buttons to work with [1] but got stuck and had to move onto other things.
The following areas work:
Summary - http:// 10.0.0. 2:5240/ MAAS/#/ machine/ wk7kxc? area=summary 10.0.0. 2:5240/ MAAS/#/ machine/ wk7kxc? area=interfaces 10.0.0. 2:5240/ MAAS/#/ machine/ wk7kxc? area=storage 10.0.0. 2:5240/ MAAS/#/ machine/ wk7kxc? area=commission ing 10.0.0. 2:5240/ MAAS/#/ machine/ wk7kxc? area=testing 10.0.0. 2:5240/ MAAS/#/ machine/ wk7kxc? area=logs 10.0.0. 2:5240/ MAAS/#/ machine/ wk7kxc? area=events 10.0.0. 2:5240/ MAAS/#/ machine/ wk7kxc? area=configurat ion
Interfaces - http://
Storage - http://
Commissioning - http://
Testing - http://
Logs - http://
Events - http://
Configuration - http://
[1] https:/ /developer. mozilla. org/en- US/docs/ Web/API/ History_ API