widelands

Games in progress get reported as "now available" on lobby join

Bug #1825932 reported by GunChleoc on 2019-04-23

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	widelands	Won't Fix	Low	Unassigned	widelands build21-rc1

Bug Description

If you go into the lobby and if there is a match X already running, the metaserver says "match X is now available", which is absolutely incorrect because nobody can join. This could confuse new players...

https://wl.widelands.org/forum/topic/2786/?page=32#post-27627

Tags:

Related branches

lp:~widelands-dev/widelands/bug-1825932-open-games

Superseded for merging into lp:widelands

Widelands Developers: Pending requested 2019-05-02

Diff: 51703 lines (+3516/-35619)

121 files modified

CMakeLists.txt (+1/-1)
data/i18n/locales.lua (+1/-7)
data/i18n/locales/sr.json (+1/-1)
data/i18n/locales/sr_RS.json (+0/-7)
data/i18n/translation_stats.conf (+5/-8)
data/txts/translators_data.lua (+1/-1)
debian/translations/sr_RS.json (+0/-9)
debian/widelands.appdata.xml (+0/-1)
po/map_the_green_plateau.wmf/map_the_green_plateau.wmf.pot (+1/-1)
po/map_the_green_plateau.wmf/sr_RS.po (+0/-160)
po/maps/da.po (+13/-13)
po/maps/maps.pot (+139/-18)
po/maps/sr_RS.po (+0/-957)
po/mp_scenario_island_hopping.wmf/mp_scenario_island_hopping.wmf.pot (+1/-1)
po/mp_scenario_island_hopping.wmf/sr_RS.po (+0/-151)
po/mp_scenario_smugglers.wmf/mp_scenario_smugglers.wmf.pot (+1/-1)
po/mp_scenario_smugglers.wmf/sr_RS.po (+0/-138)
po/scenario_atl01.wmf/ko.po (+7/-8)
po/scenario_atl01.wmf/scenario_atl01.wmf.pot (+1/-1)
po/scenario_atl01.wmf/sr_RS.po (+0/-936)
po/scenario_bar01.wmf/ko.po (+9/-10)
po/scenario_bar01.wmf/scenario_bar01.wmf.pot (+1/-1)
po/scenario_bar01.wmf/sr_RS.po (+0/-1039)
po/scenario_bar02.wmf/ko.po (+7/-8)
po/scenario_bar02.wmf/scenario_bar02.wmf.pot (+1/-1)
po/scenario_bar02.wmf/sr_RS.po (+0/-655)
po/scenario_dummy.wmf/scenario_dummy.wmf.pot (+1/-1)
po/scenario_dummy.wmf/sr.po (+16/-17)
po/scenario_dummy.wmf/sr_RS.po (+0/-37)
po/scenario_emp01.wmf/ko.po (+10/-11)
po/scenario_emp01.wmf/scenario_emp01.wmf.pot (+1/-1)
po/scenario_emp01.wmf/sr_RS.po (+0/-438)
po/scenario_emp02.wmf/da.po (+115/-120)
po/scenario_emp02.wmf/ko.po (+214/-220)
po/scenario_emp02.wmf/scenario_emp02.wmf.pot (+1/-1)
po/scenario_emp02.wmf/sr_RS.po (+0/-525)
po/scenario_emp03.wmf/da.po (+37/-83)
po/scenario_emp03.wmf/it.po (+16/-17)
po/scenario_emp03.wmf/ko.po (+105/-195)
po/scenario_emp03.wmf/scenario_emp03.wmf.pot (+1/-5)
po/scenario_emp03.wmf/sr_RS.po (+0/-1068)
po/scenario_emp04.wmf/da.po (+8/-12)
po/scenario_emp04.wmf/scenario_emp04.wmf.pot (+1/-5)
po/scenario_emp04.wmf/sr_RS.po (+0/-1328)
po/scenario_fri01.wmf/da.po (+70/-138)
po/scenario_fri01.wmf/scenario_fri01.wmf.pot (+1/-1)
po/scenario_fri01.wmf/sr_RS.po (+0/-908)
po/scenario_fri02.wmf/da.po (+8/-12)
po/scenario_fri02.wmf/fr.po (+2/-2)
po/scenario_fri02.wmf/ko.po (+4/-8)
po/scenario_fri02.wmf/scenario_fri02.wmf.pot (+1/-1)
po/scenario_fri02.wmf/sr_RS.po (+0/-859)
po/scenario_tutorial01_basic_control.wmf/da.po (+15/-15)
po/scenario_tutorial01_basic_control.wmf/ko.po (+8/-8)
po/scenario_tutorial01_basic_control.wmf/scenario_tutorial01_basic_control.wmf.pot (+1/-1)
po/scenario_tutorial01_basic_control.wmf/sr_RS.po (+0/-1045)
po/scenario_tutorial02_warfare.wmf/ko.po (+9/-9)
po/scenario_tutorial02_warfare.wmf/scenario_tutorial02_warfare.wmf.pot (+1/-1)
po/scenario_tutorial02_warfare.wmf/sr_RS.po (+0/-560)
po/scenario_tutorial03_seafaring.wmf/scenario_tutorial03_seafaring.wmf.pot (+1/-1)
po/scenario_tutorial03_seafaring.wmf/sr_RS.po (+0/-424)
po/scenario_tutorial04_economy.wmf/da.po (+51/-51)
po/scenario_tutorial04_economy.wmf/gd.po (+3/-3)
po/scenario_tutorial04_economy.wmf/scenario_tutorial04_economy.wmf.pot (+1/-1)
po/scenario_tutorial04_economy.wmf/sr_RS.po (+0/-981)
po/texts/da.po (+21/-21)
po/texts/hu.po (+12/-12)
po/texts/ko.po (+5/-6)
po/texts/sr_RS.po (+0/-787)
po/texts/texts.pot (+1/-1)
po/tribes/da.po (+450/-514)
po/tribes/ko.po (+63/-63)
po/tribes/nds.po (+46/-46)
po/tribes/sr.po (+279/-344)
po/tribes/sr_RS.po (+0/-5348)
po/tribes/tribes.pot (+69/-69)
po/tribes_encyclopedia/da.po (+101/-102)
po/tribes_encyclopedia/de.po (+61/-61)
po/tribes_encyclopedia/it.po (+63/-64)
po/tribes_encyclopedia/ko.po (+70/-71)
po/tribes_encyclopedia/sr_RS.po (+0/-6102)
po/tribes_encyclopedia/tribes_encyclopedia.pot (+45/-428)
po/widelands/da.po (+155/-156)
po/widelands/nds.po (+21/-22)
po/widelands/sr_RS.po (+0/-4773)
po/widelands/widelands.pot (+552/-627)
po/widelands_console/da.po (+22/-22)
po/widelands_console/sr_RS.po (+0/-272)
po/widelands_console/widelands_console.pot (+36/-24)
po/widelands_editor/sr_RS.po (+0/-220)
po/widelands_editor/widelands_editor.pot (+1/-1)
po/win_conditions/da.po (+41/-43)
po/win_conditions/sr.po (+98/-101)
po/win_conditions/sr_RS.po (+0/-355)
po/win_conditions/win_conditions.pot (+44/-42)
po/world/fr.po (+23/-23)
po/world/ko.po (+160/-106)
po/world/sr_RS.po (+0/-1044)
po/world/world.pot (+8/-8)
src/ai/defaultai_warfare.cc (+2/-8)
src/logic/CMakeLists.txt (+3/-10)
src/logic/game.cc (+4/-4)
src/logic/game.h (+1/-1)
src/logic/map.cc (+1/-1)
src/logic/map_objects/tribes/militarysite.cc (+0/-1)
src/logic/objective.cc (+0/-1)
src/logic/player.cc (+10/-8)
src/logic/player.h (+1/-1)
src/logic/playercommand.cc (+11/-43)
src/logic/playercommand.h (+4/-4)
src/map_io/CMakeLists.txt (+0/-1)
src/network/internet_gaming.cc (+7/-4)
src/network/internet_gaming.h (+6/-6)
src/scripting/CMakeLists.txt (+0/-1)
src/ui_basic/editbox.cc (+22/-2)
src/ui_basic/editbox.h (+5/-0)
src/ui_fsmenu/internet_lobby.cc (+41/-25)
src/wui/CMakeLists.txt (+0/-1)
src/wui/attack_box.cc (+50/-287)
src/wui/attack_box.h (+3/-79)
src/wui/fieldaction.cc (+6/-6)

lp:~widelands-dev/widelands/bug-1825932-open-games-clean-start

Merged into lp:widelands at revision 9106

GunChleoc: Approve on 2019-05-12