DRC: Wrong track clearance error type

[John Beard]

[Spun out from https://bugs.launchpad.net/kicad/+bug/1825399. This is a confounding issue of that bug, but is not the root cause]

If two tracks cross, but not at right angles, the DRC error is reported wrongly. Moreover, the error location is wrong.

1) Have two nets (e.g. T1 and T2)
2) T2 has a horizontal trace
3) Cross it with a T1 trace at 45 degrees (or any non-right-angle)
4) Run DRC
5) See "two track ends too close", not "tracks crossing".
6) Also the marker is the end point of T2, not the crossing point.

-----

Application: kicad
Version: (5.1.0-306-g4214437d1), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.63.0 OpenSSL/1.1.1a zlib/1.2.11 libidn2/2.1.0 libpsl/0.20.2 (+libidn2/2.1.0) libssh2/1.8.0 nghttp2/1.36.0
Platform: Linux 4.20.6-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.63.0
    Compiler: GCC 8.2.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision e156e4509ccee8aeaaebf8af69fc960232961414
https://git.launchpad.net/kicad/patch/?id=e156e4509ccee8aeaaebf8af69fc960232961414