column sorting state arrows in Angular eg-grid should be switched

[Galen Charlton]

The arrow icons used in the Angular eg-grid column headers that indicate whether a column is sorted currently do the following:

  sort order ascending == display _down_ arrow
  sort order descending == display _up_ arrow

This behavior can be described as having the arrow point to the last entry/highest value/end of the set of column values.

However, while this choice is not unique to eg-grid, it does seem to be rather less common than this approach:

  sort order ascending == display _up_ arrow
  sort order descending == display _descending_ arrow

In this case, an up arrow signifies ascending (upwards) sort and vice versa.

The following blog post reviews a number of table widgets; the majority do indeed use the up == ascending sort convention:

https://hackernoon.com/sorting-arrow-confusion-in-data-tables-5a3117698fdf

(I personally kinda like the _diagonal_ arrow approach, but unfortunately that's not a ready option in the iconset we're using.)

This is either a UX bug, a wishlist, or an invitation to an Emacs/Vi-style debate, but I'll shortly provide a patch to reverse the direction of the arrow. If the consensus is to merge it, I suggest backporting it to 3.3 for the sake of anybody catching up on screenshots for documentation.

Evergreen master

[Galen Charlton (gmc)]

A patch is available in the working repository:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1825578_reverse_sort_order_arrows / user/gmcharlt/lp1825578_reverse_sort_order_arrows

[Bill Erickson (berick)]

+1 to swapping the arrow direction.

Sign off pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1825578-grid-sort-arrows

Will wait a bit for comment before merging.

[Galen Charlton (gmc)]

Thanks for signing off. I'm going to use this one in my demo of how to merge patches today, so I'm grabbing the bug.

[Galen Charlton (gmc)]

Pushed to master and rel_3_3. Tnanks for testing, Bill!