eeschema segfaults on cancelled label creation and has sticky tool behavior

[Paul Hansel]

To reproduce:

1. Click the "place global label" button on the right sidebar. The global label button will not be selected, while the "place net label" button will be highlighted.

2. Type in any random label name and press enter. The actual label created will simply be a net label.

3. Press Esc (to cancel the "place net label" operation). eeschema will segfault.

If you press escape several times while the "place net label" dialog is still open, i.e. step 1, the "place net label" tool will remain active even though the "select item" tool is highlighted. This happens with several other tools.

Application: kicad
Version: (5.1.0-rc1-499-gcc18464), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.15.0-47-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Paul Hansel (paulhansel)]

Looks like the second part of this bug is the same as https://bugs.launchpad.net/kicad/+bug/1825192

[Paul Hansel (paulhansel)]

Hi Jeff, the sticky tool issue is still a problem as of 5.1.0-rc1-504-ge9c1cd2. Thanks for the fix!

Application: kicad
Version: (5.1.0-rc1-504-ge9c1cd2), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.4.0-145-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Paul Hansel (paulhansel)]

If you click on the cursor tool, it does behave correctly, but the "escape to exit tool" functionality does not work before you do that. The cursor tool is misleadingly highlighted even though the previous tool is still active.

[Jeff Young (jeyjey)]

Indeed, the <esc> key is still broken (although the context menu "End Tool" item works). I'll dig into it....

[Jeff Young (jeyjey)]

<esc> issue should be fixed now too.

[Paul Hansel (paulhansel)]

I'd say the Esc issue is fixed, but it's only working in the sense that the tool is no longer reactivated. The select tool is now broken: https://bugs.launchpad.net/kicad/+bug/1825613