login_with should not popup browser under sudo
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
launchpadlib |
Fix Released
|
High
|
Dan Streetman |
Bug Description
When running under sudo, popping up a new browser as the root user is almost certainly not a good thing to do. In fact, chromium/chrome refuses to do so, and prints:
[162589:
which (if running on graphical system) results in a pop-up showing the error:
"Failed to execute default Web Browser."
"Input/Output error."
Additionally, similar to bug 1862948, opening a browser under sudo will save any cookies or other browser data as the sudo'ed user (i.e. root, usually) instead of the calling user. This is unlikely to be what the user actually wants, and can be confusing on any system with shared root access, where user "B" may have a browser pop-up automatically log them in as user "A" and/or prefill the wrong login information.
Related branches
- Colin Watson: Approve
-
Diff: 322 lines (+171/-44)2 files modifiedsrc/launchpadlib/credentials.py (+151/-43)
src/launchpadlib/launchpad.py (+20/-1)
description: | updated |
summary: |
- login_with forces opening of browser + login_with should not popup browser under sudo |
description: | updated |
description: | updated |
Fixed in launchpadlib 1.10.11. Thanks for the contribution.