charm disables stonith despite pacemaker-remote requesting it

[Liam Young]

Stonith is being disabled at the global cluster level despite it being needed for pacemaker-remote nodes.

The legacy hacluster charm option 'stonith_enable' covers the main 'member' nodes and if it is set to false then stonith resources are not created for them and the stonith-enabled cluster parameter is set to false. However, in a masakari deploy stonith is not required for the member nodes but is for the remote nodes. In this case stonith-enabled cluster option should be set to true.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/652690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/652690
Committed: https://git.openstack.org/cgit/openstack/charm-hacluster/commit/?id=09865333a44d28825d37ad72b245044042305a1f
Submitter: Zuul
Branch: master

commit 09865333a44d28825d37ad72b245044042305a1f
Author: Liam Young <email address hidden>
Date: Mon Apr 15 15:13:24 2019 +0000

    Stop stonith-enabled being incorrectly set false.

    Stonith is being disabled at the global cluster level despite it being needed
    for pacemaker-remote nodes.

    The legacy hacluster charm option 'stonith_enable' covers the main 'member'
    nodes and if it is set to false then stonith resources are not created for
    them and the stonith-enabled cluster parameter is set to false. However, in a
    masakari deploy stonith is not required for the member nodes but is for the
    remote nodes. In this case stonith-enabled cluster option should be set to
    true.

    Change-Id: Ie1affa17dd3cfcd677aa866b6e3d1c1004bb13c9
    Closes-Bug: #1824828