while doing action-managed-upgrade with HA pause/resume, v3 endpoint does not get created as config-change is not invoked

[Rodrigo Barbieri]

Running environment Ocata:

cinder/0
  cinder-ceph/1
  cinder-hacluster/1
cinder/1*
  cinder-ceph/0*
  cinder-hacluster/0*
cinder/2
  cinder-ceph/2
  cinder-hacluster/2

While upgrading to Pike through the commands:

juju config cinder action-managed-upgrade=True
juju config cinder openstack-origin='cloud:xenial-pike'
juju run-action cinder-hacluster/0 --wait pause
juju run-action cinder/1 --wait pause
juju run-action cinder/1 --wait openstack-upgrade
juju run-action cinder/1 --wait resume
juju run-action cinder-hacluster/0 --wait resume
...
and so on for the other 2 non-leader units

results in the endpoint v3 not being registered in keystone. As can be seen in [1] there is a return preventing the config-change from invoking the code below, in [2], from creating the endpoint.

Since the openstack-upgrade nor resume actions register the endpoints, and openstack-upgrade tries to invoke the config change at [3], but doesn't accomplish so because of [1], the endpoints never get registered during the upgrade until the unit is resumed and another config-change is triggered manually.

[1] https://github.com/openstack/charm-cinder/blob/8d977e815205cc7410b6d6abd222740809e7c05b/hooks/cinder_hooks.py#L173

[2] https://github.com/openstack/charm-cinder/blob/8d977e815205cc7410b6d6abd222740809e7c05b/hooks/cinder_hooks.py#L230

[3] https://github.com/openstack/charm-cinder/blob/8d977e815205cc7410b6d6abd222740809e7c05b/actions/openstack_upgrade.py#L70

Expected behavior should be to have the v3 endpoint registered by the time the cinder unit is resumed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/653022

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/653022
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=d3332cccf9ceeca9407b4b61d1b5acfef8ea6f64
Submitter: Zuul
Branch: master

commit d3332cccf9ceeca9407b4b61d1b5acfef8ea6f64
Author: David Ames <email address hidden>
Date: Tue Apr 16 08:15:50 2019 -0700

    Automatically resume after openstack upgrade

    After an openstack upgrade automatically resume. Without this a gate in
    config_changed stops configuration of keystone catalog entries. That
    gate is still useful for the series-upgrade process.

    Change-Id: I458a1ed6ebf51263785391785cabc17f716b6178
    Closes-Bug: #1824545