Eeschema: Rotation of selected block which contains global labels not work correct

[Silviu Laurentiu]

   Place have a look to attached video.
   Many Thanks!

   Application: kicad
Version: (5.1.0)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jon Evans (craftyjon)]

So, the attached patch fixes the problem. But I'm not sure why this is the case in the first place. Maybe Wayne or JP knows?

[Wayne Stambaugh (stambaughw)]

@Jon, I cannot speak as to why the problem exists but your fix resolves the problem so please push it to the master and 5.1 branches. Thanks!

[Seth Hillbrand (sethh)]

@Wayne/@Jon- Might be better to fix it in SCH_GLOBALLABEL::SetLabelSpinStyle(). It looks like it is backwards there from the other labels.

[Seth Hillbrand (sethh)]

Note, this also happens with hierarchical labels but not with local labels.

[Jon Evans (craftyjon)]

@Seth -- wouldn't changing it in SetLabelSpinStyle (and it would need to be a few other places, too) break existing designs that use vertically oriented labels?

[KiCad Janitor (kicad-janitor)]

Fixed in revision 078fdb90779d4b7c1a7f4f3ffdda57d910e0b791
https://git.launchpad.net/kicad/patch/?id=078fdb90779d4b7c1a7f4f3ffdda57d910e0b791

[Seth Hillbrand (sethh)]

@Jon- Oh, right. Good call.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 078fdb90779d4b7c1a7f4f3ffdda57d910e0b791
https://git.launchpad.net/kicad/patch/?id=078fdb90779d4b7c1a7f4f3ffdda57d910e0b791