upgrade k8s charms broken by lxd profile checks

Bug #1824272 reported by Ian Booth
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
Critical
Ian Booth
2.5
Fix Released
Undecided
Unassigned

Bug Description

$ juju upgrade-charm mariadb-k8s --path .
Added charm "local:kubernetes/mariadb-k8s-1" to the model.
ERROR unable to set charm profile: unit "baz/0" is not assigned to a machine (not assigned)

k8s charms don't have assigned machines. The facade needs to check for a caas model and skip this step

Ian Booth (wallyworld)
description: updated
Changed in juju:
assignee: nobody → Heather Lanigan (hmlanigan)
Changed in juju:
status: Triaged → In Progress
Revision history for this message
Heather Lanigan (hmlanigan) wrote :

@wallyworld, how do i setup to deploy the local k8s charm for reproduction and testing purposes?

$ juju deploy ~/charms/mariadb-k8s/
ERROR local charm missing OCI images for: mysql_image

which is from charm pull cs:~juju/mariadb-k8s

I'm following the instructions here:
https://discourse.jujucharms.com/t/juju-kubernetes-and-microk8s/226

side note:
$ juju deploy cs:~juju/mariadb-k8s
gets stuck:
Unit Workload Agent Address Ports Message
mariadb-k8s/0 waiting allocating waiting for container

Revision history for this message
Heather Lanigan (hmlanigan) wrote :

I now remember to build the charm, use to the old ones with no building after charm pull... but building the charm fails:

$ charm build -o builds/mariadb-k8s-build src/mariadb-k8s/
build: Destination charm directory: /home/heather/charms/builds/mariadb-k8s-build/builds/mariadb-k8s
build: Processing layer: layer:options
build: Processing layer: layer:status
build: Processing layer: layer:caas-base
build: Processing layer: layer:docker-resource
build: Processing layer: mariadb-k8s (from src/mariadb-k8s)
build: Processing interface: mysql
charmtools.build.tactics: Options set for undefined layer: mariadb-k8s

Revision history for this message
Heather Lanigan (hmlanigan) wrote :

In theory, SetCharmProfile() should not have been called due to early exit in setCharmWithAgentValidation() with a CAAS model: https://github.com/juju/juju/blob/develop/apiserver/facades/client/application/application.go#L926

The db says that the model is a caas type.
juju:PRIMARY> db.models.find({},{"name" :1, "type" :1})
{ "_id" : "fa6a0114-d944-419e-84de-66a3b75b3194", "name" : "controller", "type" : "iaas" }
{ "_id" : "5440e0f6-6e8b-4912-8884-bf91c594207c", "name" : "test", "type" : "caas" }

Need the reproducer to continue.

Revision history for this message
Heather Lanigan (hmlanigan) wrote :

Got the cs:~juju/mariadb-k8s charm installed.

Ian Booth (wallyworld)
Changed in juju:
assignee: Heather Lanigan (hmlanigan) → Ian Booth (wallyworld)
status: In Progress → Fix Committed
Revision history for this message
Heather Lanigan (hmlanigan) wrote :

Fix in develop has been previously committed.

For 2.5: https://github.com/juju/juju/pull/10032

Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.