Institution tags have wrong text when selected

[Cecilia Vela Gurovic]

This bug is low priority because when the page is saved, the tag is saved as institution tag

to replicate:
Have an institution 'Institution one' with institution tags enabled
create institution tag 'One'
login with a user that belongs to the institution
create a page and, under the tags field, type 'One'
select the institution tag 'Institution one: One'

expect result: The tag 'Institution one: One' is displayed in the tags field
actual result: The tag 'One' is displayed in the tags field

[Kristina Hoeppner (kris-hoeppner)]

This may be looked at along with bug #1839223

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10329

[Rangi Daymond (rangid)]

Patchset: https://reviews.mahara.org/#/c/10329/
Browser tested: Firefox & Chrome
Theme used: Default

**TEST SCENARIO: Verify that an institution tag remains displayed as an institution tag after a user selects it from the drop-down options when creating new page tag entry/ies after typing the exact tag name (without the preceding institute name & colon) then selecting it from the dropdown (please see attached re-created defect screenshots prefixed with SS1-1 and SS1-2).
--------------

**PRECONDITIONS:
---------------
1) An institution 'Institution one' exists with an institution tag named 'One'
2) A user1 (e.g. 'Bob User2') is a member of the above institute and has some prior tags

**TEST STEPS:
-------------
Step1) Logged in user1 selects to create a new page --> the new page screen is displayed
Step2) User1 types the 3 characters One into the new page 'Tags' field --> the option 'Institution one: One' is displayed
Step3) User1 selects the displayed option

Expected resultA: the selected Tags content now says ''Institution one: One (0)' --pre-fix was just displaying 'One'
Actual result: as expected (see attachment prefixed with SS2) ✓

Step4) the user Saves the tag (with or without putting a title and some content on the page)
Step5) the user then selects the Create tags option

Expected resultB: the My tags page will be displayed with the tag 'Institution one: One' option and a zero displayed in the circle next to it X - Failed
Actual resultB: (please see attachement prefixed with SS3) the My tags page is displayed with the tag 'Institution one: One (0)' option and a one displayed in the circle next to it.

[Rangi Daymond (rangid)]

Gerrit/Patchset: https://reviews.mahara.org/mahara refs/changes/29/10329/2
Browser tested: Firefox & Chrome
Theme used: Default

**TEST SCENARIO: Verify that institution tag names are displayed correctly on user Tag pages.
----------------

**PRECONDITIONS:
---------------
1) An institution 'Institution1' exists with an institution tag named 'InstitutionTag'
2) A user1 (e.g. 'Bob User2') is a member of the above institute and has some prior tags

**TEST STEPS:
-------------
Step1) Logged in user1 selects to create a new page --> the new page screen is displayed
Step2) User1 types the exact value 'InstitutionTag' into the new page 'Tags' field --> the options 'InstitutionTag' and 'Institution1: InstitutionTag (1)' are displayed.
Step3) User1 selects the second option displayed option.
Step4) the user displays the page and tag --> the page, tag name and count displays correctly.
Step5) the user then selects the Create tags option.

Expected result: the My tags page will be displayed with the user's tag names and associated counts showing correctly.
Actual result: as expected (see attached screenshot from Firefox). ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10329
Committed: https://git.mahara.org/mahara/mahara/commit/c9a33e3ea7ebb4cee8a09bebf9ca35f4b64e2f3f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c9a33e3ea7ebb4cee8a09bebf9ca35f4b64e2f3f
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 10 16:04:37 2019 +1200

Bug 1824263: Institution tags have wrong text when
selected

changed the 'id' to use the display tag.
updated the call to display_tags to not show count

behatnotneeded

Change-Id: Ibac85aedb783c2a83e230842de560e2c67e5827e
Signed-off-by: Lisa Seeto <email address hidden>