bad health check logic in common.sh results in error

[Alex Schultz]

It looks like the logic might be bad in one of the swift health checks. I noticed this in the journal:

Apr 10 21:47:59 overcloud-controller-0 systemd[1]: Starting nova_scheduler healthcheck...
Apr 10 21:47:59 overcloud-controller-0 systemd[1]: Started nova_scheduler healthcheck.
Apr 10 21:47:59 overcloud-controller-0 podman[402618]: stat: cannot stat '/var/cache/swift/object.recon': No such file or directory
Apr 10 21:47:59 overcloud-controller-0 podman[402618]: /usr/share/openstack-tripleo-common/healthcheck/common.sh: line 55: [: 1554932579: unary operator expected
Apr 10 21:47:59 overcloud-controller-0 systemd[1]: Started swift_proxy healthcheck.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/651658

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/651658
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=26967343482ff1df5976d4da2d5b598e364362cf
Submitter: Zuul
Branch: master

commit 26967343482ff1df5976d4da2d5b598e364362cf
Author: Alex Schultz <email address hidden>
Date: Wed Apr 10 16:09:18 2019 -0600

    Check for file existance in file modification check

    We sometimes start health checks before a file is actually written out
    by the service. This results in a bash error in the logs. Let's check
    the file exists before trying to use it in the health check.

    Change-Id: I58815050117af20abc547f46d15073ac0bf8ca74
    Closes-Bug: #1824246

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/654570

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/654570
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=992749c69fd1414148f26b60dbf9beb48f23f960
Submitter: Zuul
Branch: stable/stein

commit 992749c69fd1414148f26b60dbf9beb48f23f960
Author: Alex Schultz <email address hidden>
Date: Wed Apr 10 16:09:18 2019 -0600

    Check for file existance in file modification check

    We sometimes start health checks before a file is actually written out
    by the service. This results in a bash error in the logs. Let's check
    the file exists before trying to use it in the health check.

    Change-Id: I58815050117af20abc547f46d15073ac0bf8ca74
    Closes-Bug: #1824246
    (cherry picked from commit 26967343482ff1df5976d4da2d5b598e364362cf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.8.0 release.