default network config deployment fails with Unknown Property StorageNetworkVlanID

[Alex Schultz]

Trying to deploy the default network config (all on ctlplane) is failing with:

Error during stack creation: ERROR: Property error: : resources.Compute<nested_stack>.resources.0<http://192.168.24.1:8080/v1/AUTH_f0297cac4cff4a73ac2d6118652b6f85/overcloud/puppet/compute-role.yaml>.resources.NetworkConfig.properties: : Unknown Property StorageNetworkVlanID
None

Deployment command:
openstack tripleo container image prepare defaults --output-env-file containers-prepare-parameters.yaml

cat > ~/params.yaml <<EOF
resource_registry:
  OS::TripleO::Services::Docker: OS::Heat::None
  OS::TripleO::Services::Snmp: OS::Heat::None
parameter_defaults:
  SELinuxMode: permissive
  PythonInterpreter: /usr/bin/python3
  NovaComputeLibvirtType: qemu
  ControllerCount: 1
  ComputeCount: 1
  ExtraConfig:
    glance_backend: 'file'
EOF

export THT=/usr/share/openstack-tripleo-heat-templates
openstack overcloud deploy --templates $THT/ \
  --timeout 100 \
  -e $THT/environments/enable-swap.yaml \
  -e $THT/environments/disable-telemetry.yaml \
  -e $THT/environments/docker-ha.yaml \
  -e $THT/environments/podman.yaml \
  -e $THT/environments/services/neutron-ovn-ha.yaml \
  -e containers-prepare-parameters.yaml -e params.yaml

[Alex Schultz (alex-schultz)]

Might have been introduced via https://review.openstack.org/#/c/645159/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/651381

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/651381
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=56a51647c34bd38788415c9923a25893c60b7b81
Submitter: Zuul
Branch: master

commit 56a51647c34bd38788415c9923a25893c60b7b81
Author: Harald Jensås <email address hidden>
Date: Tue Apr 9 23:00:37 2019 +0200

    Add {{network.name}}NetworkVlanID to THT/net-config-*

    With the default network_data.yaml and default roles_data.yaml
    all composable networks are included. When deploying plain
    defaults without any network-isolation, i.e ctlplane network
    only the jinja2 rendered templates still include all the nets.

    With change: https://review.openstack.org/645159 the vlan
    parameter is passed to NIC configs for all networks enabled
    for the role in roles data if networks data define a vlan id.

    Because of this we need to add the parameter to the nic config
    template unless networks data and roles data are customized.
    (i.e networks that are'nt actually used are removed from the
    roles data and networks data.)

    Closes-Bug: #1823997
    Change-Id: Ic5fe9c8097de814ce3ad7032f42b31859051f70a

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.5.0 release.