Don't fail a deployment when configuring external ceph if the ceph-ansible fetch directory is empty, this is OK

[John Fulton]

When deploying with:

-e /usr/share/openstack-tripleo-heat-templates/environments/ceph-ansible/ceph-ansible-external.yaml

we see this error:

"TASK [create temporary ceph-ansible fetch directory tarball for swift backup]"
fatal: [undercloud]: FAILED! => {"changed": false, "expanded_paths": "", "msg": "Error, no source paths were found", "path": "/var/lib/mistral/overcloud/ceph-ansible/fetch_dir/*", "state": "absent"}

but it's very normal for there to be no fetch directory if you're doing an external ceph deployment. We shouldn't fail for this reason.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/650953

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/650953
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=031f5fb6103a3a0313048b51af2ec7e12f48c28c
Submitter: Zuul
Branch: master

commit 031f5fb6103a3a0313048b51af2ec7e12f48c28c
Author: John Fulton <email address hidden>
Date: Mon Apr 8 12:25:33 2019 -0400

    Do not archive ceph-ansible fetch directory if it is empty

    There are conditions, e.g. external ceph deployment, where
    ceph-ansible will not produce a fetch directory so we should
    not always assume there is something to archive.

    Add a task to register the contents of the ceph-ansible fetch
    directory and only archive that directory if the contents exist.

    Also, remove the '--no-overwrite-dir' option from tar as it
    seems to have broken repeat deployments.

    Change-Id: I56eae30d73bf5cc6b1ae413c6841f86c2a4e86b5
    Closes-Bug: #1823759
    Closes-Bug: #1823229

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/651651

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/651651
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f24f23b96f000b6b6eb1d82c6628d52d268a5e7b
Submitter: Zuul
Branch: stable/rocky

commit f24f23b96f000b6b6eb1d82c6628d52d268a5e7b
Author: John Fulton <email address hidden>
Date: Mon Apr 8 12:25:33 2019 -0400

    Do not archive ceph-ansible fetch directory if it is empty

    There are conditions, e.g. external ceph deployment, where
    ceph-ansible will not produce a fetch directory so we should
    not always assume there is something to archive.

    Add a task to register the contents of the ceph-ansible fetch
    directory and only archive that directory if the contents exist.

    Also, remove the '--no-overwrite-dir' option from tar as it
    seems to have broken repeat deployments.

    Change-Id: I56eae30d73bf5cc6b1ae413c6841f86c2a4e86b5
    Closes-Bug: #1823759
    Closes-Bug: #1823229
    (cherry picked from commit 031f5fb6103a3a0313048b51af2ec7e12f48c28c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.0 release.