Barbarian TrainingCamp: Help contains Building from Frisians

Bug #1823467 reported by Klaus Halfmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

Check the help for a Barrian TrainingCamp it contains a small armor smithy (or such).
German: Hilfe für das Ausblildungslager enhält Hinweis auf kleine Rüstungsschmiede"

Low prio, but perhaps we can fix it for R20?

Tags: help

Related branches

Revision history for this message
GunChleoc (gunchleoc) wrote :

Confirmed - it's in the equipment for Health training. Well spotted!

I'd like this fixed for Build 20 if it's easy to fix, because it will be very confusing to new players.

tags: added: help
Changed in widelands:
milestone: none → build20-rc1
GunChleoc (gunchleoc)
Changed in widelands:
status: New → Confirmed
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Ok this is due to the ware "helmet" is used by barbarians and frisians. Quick fix would be to have different wares but this would not be my favourite. I'll try to implement a fix which checks for the tribe having the building

Revision history for this message
GunChleoc (gunchleoc) wrote :

Exactly - Fix is to check tribe:has_building. I'll take care of it. I wrote the code, so I'll find it faster.

Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I would have done it completely in lua due to my non-abilities in c++ but your solution looks better.
Thanks for saving me work.

Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.