Import vector graphic dialog box

[Hildo Guillardi Júnior]

I am trying to import a SVG/DXF file format into PCBnew.

1) The dialog have some issues:
- The placement are both selected (the option box is not working);
- The blank space before the "import parameters" is too big.

[Hildo Guillardi Júnior (hildogjr)]

Also the section title use bold text and huge text size. This is not coherent with the other dialogs style.

[Hildo Guillardi Júnior (hildogjr)]

Other issue: the selected unit, when the dialog opens, is always millimeters (I use that) but should this follow the current unit of the canvas?

[Hildo Guillardi Júnior (hildogjr)]

My version:

Application: pcbnew
Version: 5.1.0-unknown-1ae47b6~82~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.15.0-47-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[jean-pierre charras (jp-charras)]

The dxf file shows nothing, both in FreeCAD and AcmeCad.

The svg file contains no graphic item: It contains only a bitmap and 2 texts, obviously not importable as graphic outlines.

[Hildo Guillardi Júnior (hildogjr)]

Understood.
So:

1) The dialog need a fix (this is low priority);
2) Should clear (some text on top of the dialog before the file import textbox): "import graphical outlines". The title "import vector graphics file" took me to this misunderstood;
3) The import of images stays to lp:1728272.

[Wayne Stambaugh (stambaughw)]

"Import Graphical Outlines" isn't entirely correct either. Honestly "Import Vector Graphics File" is what this feature actually does. Bitmaps in a vector graphics file are not vector graphics. I would be open on adding a tool tip that states the non-vector graphics in these files will not be imported.

The only time the units should be the currently selected units in the board editor is the very first time the dialog is open. Currently the last setting used in the dialog is saved between sessions which I feel is the correct behavior.

As for the bold static text that separates the sections of the dialog, it does look different than most of our dialogs. Personally I'm not a fan of the boxes we draw around everything but I agree we should be more consistent.

The only fixes I see here are a tool tip to explain that only the vectors will be imported and the dialog layout issues.

[KiCad Janitor (kicad-janitor)]

Fixed in revision f7550940ee5d676483f95f3ee32561e667fd9573
https://git.launchpad.net/kicad/patch/?id=f7550940ee5d676483f95f3ee32561e667fd9573