Port Org Unit Type editor to Angular / FM Editor Translate Buttons

Bug #1823393 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen 3.3

Continuing the push toward deprecating Dojo/embedded UI's, here's a bug for porting the Org Unit Type admin UI from Dojo to Angular.

Branch on the way which implements the UI and adds support for displaying a "Translate" button next to i18n fields in the FmRecordEditorComponent.

It also includes some fixes to the Angular TreeComponent.

Revision history for this message
Bill Erickson (berick) wrote :
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
milestone: none → 3.next
tags: added: pullrequest
Bill Erickson (berick)
Changed in evergreen:
status: In Progress → New
Bill Erickson (berick)
Changed in evergreen:
milestone: 3.next → 3.4-beta1
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed a signoff branch to

working/user/gmcharlt/lp1823393_angular-aout-admin-signoff
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1823393_angular-aout-admin-signoff

The branch also includes release notes and a patch that makes some usability improvements:

    - display the number of org units associated with the selected type
    - disable the Delete button if a type either has children types
      or org units linked to it
    - ensure that the type name and label fields are required
    - ensure that the tree is fully refreshed after an update

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
importance: Undecided → Wishlist
status: New → Confirmed
tags: added: signedoff
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Galen. I reviewed and tested your additions. Signoffs for the new commits pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1823393-angular-org-unit-types-admin-signoff2

All commits now signed off.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

This interface looks great and works well. Thanks, Bill and Galen! Pushed to master so that it can be included in 3.4.

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.