Optionally require ident_value

Bug #1823255 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

It would be nice if libraries could make the Primary Identification (ident_value) field required in the patron editor, as they can do for some other fields.

An example use case: you're an academic library and you use the ident_value field to track student/employee ID numbers. If staff are registering patrons at the circ desk, you want to ensure that they include the ID number. Requiring ident_value is a way to enforce that.

Tags: pullrequest
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1823255_make_ident_value_required has a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1823255_make_ident_value_required

(No attempt has been made to address bug 1631005, a related but orthogonal issue which is beyond the scope of the present feature request.)

tags: added: pullrequest
Changed in evergreen:
importance: Undecided → Wishlist
milestone: none → 3.next
Changed in evergreen:
milestone: 3.next → 3.4-beta1
Revision history for this message
Ben Shum (bshum) wrote :

Hmm, noting that the submitted code was authored by Mark Bucholtz <email address hidden>, but is missing the Signed-off-by line for them. We need to get his signoff on the commit properly, or get a DCO from Mark to allow the code to be used.

Otherwise seems fine.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/mbucholtz/lp1823255_signoff has the same fix, but with Mark's signoff included.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Sorry, user/jeffdavis/lp1823255_signoff

Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.4. Thanks, Mark and Jeff!

Changed in evergreen:
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.