undercloud host iscsid socket activation started after reboot

[James Slagle]

After rebooting the undercloud, the host's iscsid socket activation by systemd is started. This will cause any connections on the iscsi port to start the host's iscsid service, which will then cause problems with the containerized ironic conductor.

In my environment, this caused ironic conductor to fail initiation with the iscsi target with this error:

Stderr: u'iscsiadm: Cannot perform discovery. Invalid Initiatorname.\niscsiadm: Could not perform SendTargets discovery: invalid parameter\n' for node fbe614d0-8ebd-4693-b1cd-2a3ba0591944: InstanceDeployFailure: Deploy failed for instance 8464ce70-0e0b-47f3-a4fd-6c836a323d37. Error: Unexpected error while running command.
Stderr: u'iscsiadm: Cannot perform discovery. Invalid Initiatorname.\niscsiadm: Could not perform SendTargets discovery: invalid parameter\n'
2019-04-04 16:53:29.463 8 ERROR ironic.drivers.modules.agent_base_vendor Stderr: u'iscsiadm: Cannot perform discovery. Invalid Initiatorname.\niscsiadm: Could not perform SendTargets discovery: invalid parameter\n'

Stopping the host's iscsid and iscsid.socket and iscsiuio.socket services seemed to fix it.

[Emilien Macchi (emilienm)]

https://asciinema.org/a/qdYQfz0GHOkbrD0gWQlu6w7Zl

this is not a bug in TripleO but when you install libguestfs-tools (and I do the same). Which installs the iscsid socket :(.

I think we could document that somewhere, but not sure what we can do in the code. Closing this bug for now but feel free to re-open if you have a better idea.